test: cover legacy runtime deps update recovery (#75288)

scripts/e2e/lib/upgrade-survivor/run.sh

@@ -234,6 +234,80 @@ package_root() {
   printf '%s/lib/node_modules/openclaw\n' "$npm_config_prefix"
 }
 
+legacy_runtime_deps_symlink_plugin() {
+  local plugin="${OPENCLAW_UPGRADE_SURVIVOR_LEGACY_RUNTIME_DEPS_SYMLINK:-}"
+  if [ -z "$plugin" ]; then
+    return 1
+  fi
+  case "$plugin" in
+    *[!A-Za-z0-9._-]*)
+      echo "OPENCLAW_UPGRADE_SURVIVOR_LEGACY_RUNTIME_DEPS_SYMLINK must be a plugin id, got: $plugin" >&2
+      return 2
+      ;;
+  esac
+  printf '%s\n' "$plugin"
+}
+
+legacy_runtime_deps_symlink_target() {
+  local plugin="$1"
+  printf '%s/dist/extensions/%s/node_modules\n' "$(package_root)" "$plugin"
+}
+
+legacy_runtime_deps_symlink_source() {
+  local plugin="$1"
+  printf '%s/.local/bundled-plugin-runtime-deps/%s-upgrade-survivor/node_modules\n' \
+    "$(package_root)" \
+    "$plugin"
+}
+
+seed_legacy_runtime_deps_symlink() {
+  local plugin
+  plugin="$(legacy_runtime_deps_symlink_plugin)" || {
+    local status=$?
+    [ "$status" -eq 1 ] && return 0
+    return "$status"
+  }
+
+  local plugin_dir
+  plugin_dir="$(package_root)/dist/extensions/$plugin"
+  if [ ! -d "$plugin_dir" ]; then
+    echo "cannot seed legacy runtime deps symlink; packaged plugin is missing: $plugin_dir" >&2
+    return 1
+  fi
+
+  local source_dir
+  local target_dir
+  source_dir="$(legacy_runtime_deps_symlink_source "$plugin")"
+  target_dir="$(legacy_runtime_deps_symlink_target "$plugin")"
+  mkdir -p "$source_dir"
+  printf '{"name":"openclaw-upgrade-survivor-legacy-runtime-deps","version":"0.0.0"}\n' \
+    >"$source_dir/package.json"
+  rm -rf "$target_dir"
+  ln -s "$source_dir" "$target_dir"
+  if [ ! -L "$target_dir" ]; then
+    echo "failed to create legacy runtime deps symlink: $target_dir" >&2
+    return 1
+  fi
+  echo "Seeded legacy runtime deps symlink for $plugin: $target_dir -> $source_dir"
+}
+
+assert_legacy_runtime_deps_symlink_repaired() {
+  local plugin
+  plugin="$(legacy_runtime_deps_symlink_plugin)" || {
+    local status=$?
+    [ "$status" -eq 1 ] && return 0
+    return "$status"
+  }
+
+  local target_dir
+  target_dir="$(legacy_runtime_deps_symlink_target "$plugin")"
+  if [ -L "$target_dir" ]; then
+    echo "legacy runtime deps symlink survived package update: $target_dir -> $(readlink "$target_dir")" >&2
+    return 1
+  fi
+  echo "Legacy runtime deps symlink repaired for $plugin."
+}
+
 read_installed_version() {
   node -p 'JSON.parse(require("node:fs").readFileSync(process.argv[1] + "/package.json", "utf8")).version' "$(package_root)"
 }
@@ -450,8 +524,10 @@ phase seed-state seed_state
 phase apply-baseline-config-recipe apply_baseline_config_recipe
 phase validate-baseline-config validate_baseline_config
 phase assert-baseline assert_baseline_state
+phase seed-legacy-runtime-deps-symlink seed_legacy_runtime_deps_symlink
 phase resolve-candidate resolve_candidate_version
 phase update-candidate update_candidate
+phase assert-legacy-runtime-deps-symlink-repaired assert_legacy_runtime_deps_symlink_repaired
 phase doctor run_doctor
 phase validate-post-doctor-config validate_post_doctor_config
 phase assert-survival assert_survival

scripts/e2e/upgrade-survivor-docker.sh

@@ -83,6 +83,7 @@ if [ "${OPENCLAW_UPGRADE_SURVIVOR_PUBLISHED_BASELINE:-0}" = "1" ]; then
     -e OPENCLAW_UPGRADE_SURVIVOR_CANDIDATE_KIND="$CANDIDATE_KIND" \
     -e OPENCLAW_UPGRADE_SURVIVOR_CANDIDATE_SPEC="$CANDIDATE_SPEC" \
     -e OPENCLAW_UPGRADE_SURVIVOR_SCENARIO="$SCENARIO" \
+    -e OPENCLAW_UPGRADE_SURVIVOR_LEGACY_RUNTIME_DEPS_SYMLINK="${OPENCLAW_UPGRADE_SURVIVOR_LEGACY_RUNTIME_DEPS_SYMLINK:-}" \
     -e OPENCLAW_UPGRADE_SURVIVOR_SUMMARY_JSON=/tmp/openclaw-upgrade-survivor-artifacts/summary.json \
     -e OPENCLAW_UPGRADE_SURVIVOR_START_BUDGET_SECONDS="${OPENCLAW_UPGRADE_SURVIVOR_START_BUDGET_SECONDS:-90}" \
     -e OPENCLAW_UPGRADE_SURVIVOR_STATUS_BUDGET_SECONDS="${OPENCLAW_UPGRADE_SURVIVOR_STATUS_BUDGET_SECONDS:-30}" \

scripts/lib/bundled-runtime-deps-stage-state.mjs

@@ -95,10 +95,22 @@ export function assertPathIsNotSymlink(targetPath, label) {
   }
 }
 
-function isPathInside(parentPath, childPath) {
+function isDirectChildPath(parentPath, childPath) {
   const relativePath = path.relative(parentPath, childPath);
   return (
-    relativePath.length > 0 && !relativePath.startsWith("..") && !path.isAbsolute(relativePath)
+    relativePath.length > 0 &&
+    !relativePath.startsWith("..") &&
+    !path.isAbsolute(relativePath) &&
+    !relativePath.includes(path.sep)
+  );
+}
+
+function isLegacyBundledRuntimeDepsNodeModulesPath(targetPath, repoRoot, linkedPath) {
+  const legacyRuntimeDepsRoot = path.resolve(repoRoot, ".local", "bundled-plugin-runtime-deps");
+  const resolvedLinkedPath = path.resolve(path.dirname(targetPath), linkedPath);
+  return (
+    path.basename(resolvedLinkedPath) === "node_modules" &&
+    isDirectChildPath(legacyRuntimeDepsRoot, path.dirname(resolvedLinkedPath))
   );
 }
 
@@ -116,18 +128,13 @@ export function removeLegacyBundledRuntimeDepsSymlink(targetPath, repoRoot) {
     return false;
   }
 
-  const legacyRuntimeDepsRoot = path.resolve(repoRoot, ".local", "bundled-plugin-runtime-deps");
   let linkedPath;
   try {
     linkedPath = fs.readlinkSync(targetPath);
   } catch {
     return false;
   }
-  const resolvedLinkedPath = path.resolve(path.dirname(targetPath), linkedPath);
-  if (
-    path.basename(resolvedLinkedPath) !== "node_modules" ||
-    !isPathInside(legacyRuntimeDepsRoot, resolvedLinkedPath)
-  ) {
+  if (!isLegacyBundledRuntimeDepsNodeModulesPath(targetPath, repoRoot, linkedPath)) {
     return false;
   }