From 019f4a5bb87687e6e2d7ee9c1307bf23d193894e Mon Sep 17 00:00:00 2001
From: Peter Steinberger <steipete@gmail.com>
Date: Fri, 1 May 2026 22:16:46 +0100
Subject: [PATCH] refactor: remove stale plugin test cache hooks

---
 src/plugins/manifest-model-suppression.test.ts |  2 --
 src/plugins/manifest-model-suppression.ts      |  4 ----
 src/plugins/setup-registry.test.ts             |  5 -----
 src/plugins/setup-registry.ts                  | 14 --------------
 4 files changed, 25 deletions(-)

diff --git a/src/plugins/manifest-model-suppression.test.ts b/src/plugins/manifest-model-suppression.test.ts
index 29e281a6aa0..2e30fedf647 100644
--- a/src/plugins/manifest-model-suppression.test.ts
+++ b/src/plugins/manifest-model-suppression.test.ts
@@ -10,13 +10,11 @@ vi.mock("./plugin-registry.js", () => ({
 
 import {
   buildManifestBuiltInModelSuppressionResolver,
-  clearManifestModelSuppressionCacheForTest,
   resolveManifestBuiltInModelSuppression,
 } from "./manifest-model-suppression.js";
 
 describe("manifest model suppression", () => {
   beforeEach(() => {
-    clearManifestModelSuppressionCacheForTest();
     mocks.loadPluginManifestRegistryForPluginRegistry.mockReset();
     mocks.loadPluginManifestRegistryForPluginRegistry.mockReturnValue({
       diagnostics: [],
diff --git a/src/plugins/manifest-model-suppression.ts b/src/plugins/manifest-model-suppression.ts
index 19283349d78..18df4e90215 100644
--- a/src/plugins/manifest-model-suppression.ts
+++ b/src/plugins/manifest-model-suppression.ts
@@ -99,10 +99,6 @@ function manifestSuppressionMatchesConditions(params: {
   return true;
 }
 
-export function clearManifestModelSuppressionCacheForTest(): void {
-  // Manifest suppressions are read fresh. Keep the test hook as a no-op.
-}
-
 export function buildManifestBuiltInModelSuppressionResolver(params: {
   config?: OpenClawConfig;
   workspaceDir?: string;
diff --git a/src/plugins/setup-registry.test.ts b/src/plugins/setup-registry.test.ts
index 6189c692c88..8d44561eb02 100644
--- a/src/plugins/setup-registry.test.ts
+++ b/src/plugins/setup-registry.test.ts
@@ -22,7 +22,6 @@ const tempDirs: string[] = [];
 const mocks = getRegistryJitiMocks();
 
 let clearPluginSetupRegistryCache: typeof import("./setup-registry.js").clearPluginSetupRegistryCache;
-let setupRegistryTesting: typeof import("./setup-registry.js").__testing;
 let resolvePluginSetupRegistry: typeof import("./setup-registry.js").resolvePluginSetupRegistry;
 let resolvePluginSetupProvider: typeof import("./setup-registry.js").resolvePluginSetupProvider;
 let resolvePluginSetupCliBackend: typeof import("./setup-registry.js").resolvePluginSetupCliBackend;
@@ -177,7 +176,6 @@ describe("setup-registry getJiti", () => {
     resetRegistryJitiMocks();
     vi.resetModules();
     ({
-      __testing: setupRegistryTesting,
       clearPluginSetupRegistryCache,
       resolvePluginSetupRegistry,
       resolvePluginSetupProvider,
@@ -806,7 +804,6 @@ describe("setup-registry getJiti", () => {
 
     expect(resolvePluginSetupProvider({ provider: "openai", env: {} })?.id).toBe("openai");
     expect(resolvePluginSetupProvider({ provider: "anthropic", env: {} })?.id).toBe("anthropic");
-    expect(setupRegistryTesting.getCacheSizes().setupProvider).toBe(0);
     expect(resolvePluginSetupProvider({ provider: "openai", env: {} })?.id).toBe("openai");
 
     expect(resolvePluginSetupCliBackend({ backend: "codex-cli", env: {} })?.backend.id).toBe(
@@ -815,7 +812,6 @@ describe("setup-registry getJiti", () => {
     expect(resolvePluginSetupCliBackend({ backend: "claude-cli", env: {} })?.backend.id).toBe(
       "claude-cli",
     );
-    expect(setupRegistryTesting.getCacheSizes().setupCliBackend).toBe(0);
     expect(resolvePluginSetupCliBackend({ backend: "codex-cli", env: {} })?.backend.id).toBe(
       "codex-cli",
     );
@@ -828,7 +824,6 @@ describe("setup-registry getJiti", () => {
       env: {},
       pluginIds: ["anthropic"],
     });
-    expect(setupRegistryTesting.getCacheSizes().setupRegistry).toBe(0);
     expect(loadSetupModule).toHaveBeenCalledTimes(7);
   });
 });
diff --git a/src/plugins/setup-registry.ts b/src/plugins/setup-registry.ts
index 35d6c3bd864..a2957f9b903 100644
--- a/src/plugins/setup-registry.ts
+++ b/src/plugins/setup-registry.ts
@@ -84,20 +84,6 @@ const NOOP_LOGGER: PluginLogger = {
 
 const jitiLoaders: PluginJitiLoaderCache = new Map();
 
-export const __testing = {
-  get maxSetupLookupCacheEntries() {
-    return 0;
-  },
-  setMaxSetupLookupCacheEntriesForTest(_value?: number) {},
-  getCacheSizes() {
-    return {
-      setupRegistry: 0,
-      setupProvider: 0,
-      setupCliBackend: 0,
-    };
-  },
-} as const;
-
 export function clearPluginSetupRegistryCache(): void {
   jitiLoaders.clear();
 }