From 04cd389ef8408290441890d83cf16aa0308498d3 Mon Sep 17 00:00:00 2001 From: Vincent Koc Date: Sun, 22 Mar 2026 20:17:01 -0700 Subject: [PATCH] fix(ci): repair voice-call typing and provider contracts --- extensions/voice-call/src/manager/outbound.test.ts | 14 +++++++++----- src/plugins/contracts/registry.ts | 6 +++--- 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/extensions/voice-call/src/manager/outbound.test.ts b/extensions/voice-call/src/manager/outbound.test.ts index 73d2bf28330..71305799091 100644 --- a/extensions/voice-call/src/manager/outbound.test.ts +++ b/extensions/voice-call/src/manager/outbound.test.ts @@ -1,4 +1,5 @@ import { beforeEach, describe, expect, it, vi } from "vitest"; +import type { CallManagerContext } from "./context.js"; const { addTranscriptEntryMock, @@ -58,7 +59,10 @@ describe("voice-call outbound helpers", () => { }); it("guards initiateCall when provider, webhook, capacity, or fromNumber are missing", async () => { - const base = { + const base: Pick< + CallManagerContext, + "activeCalls" | "providerCallIdMap" | "config" | "storePath" | "webhookUrl" + > = { activeCalls: new Map(), providerCallIdMap: new Map(), config: { @@ -70,7 +74,7 @@ describe("voice-call outbound helpers", () => { }; await expect( - initiateCall({ ...(base as never), provider: undefined }, "+14155550123"), + initiateCall({ ...base, provider: undefined } as never, "+14155550123"), ).resolves.toEqual({ callId: "", success: false, @@ -79,7 +83,7 @@ describe("voice-call outbound helpers", () => { await expect( initiateCall( - { ...(base as never), provider: { name: "twilio" }, webhookUrl: undefined }, + { ...base, provider: { name: "twilio" }, webhookUrl: undefined } as never, "+14155550123", ), ).resolves.toEqual({ @@ -102,10 +106,10 @@ describe("voice-call outbound helpers", () => { await expect( initiateCall( { - ...(base as never), + ...base, provider: { name: "twilio" }, config: { ...base.config, fromNumber: "" }, - }, + } as never, "+14155550123", ), ).resolves.toEqual({ diff --git a/src/plugins/contracts/registry.ts b/src/plugins/contracts/registry.ts index 8c1fbb3a7ed..6ad03b97e3d 100644 --- a/src/plugins/contracts/registry.ts +++ b/src/plugins/contracts/registry.ts @@ -38,7 +38,7 @@ import xiaomiPlugin from "../../../extensions/xiaomi/index.js"; import zaiPlugin from "../../../extensions/zai/index.js"; import { bundledWebSearchPluginRegistrations } from "../../bundled-web-search-registry.js"; import { createCapturedPluginRegistration } from "../captured-registration.js"; -import { resolvePluginProviders } from "../providers.js"; +import { resolvePluginProviders } from "../provider-auth-choice.runtime.js"; import type { ImageGenerationProviderPlugin, MediaUnderstandingProviderPlugin, @@ -139,10 +139,10 @@ function loadBundledProviderRegistry(): ProviderContractEntry[] { cache: false, activate: false, }) - .filter((provider): provider is ProviderPlugin & { pluginId: string } => + .filter((provider: ProviderPlugin): provider is ProviderPlugin & { pluginId: string } => Boolean(provider.pluginId), ) - .map((provider) => ({ + .map((provider: ProviderPlugin & { pluginId: string }) => ({ pluginId: provider.pluginId, provider, }));