From 08ecf63bb608544dd9148ec02fd4e6846b48ff63 Mon Sep 17 00:00:00 2001 From: Peter Steinberger Date: Thu, 16 Jul 2026 03:05:32 +0100 Subject: [PATCH] fix(deadcode): resolve strict-workspace fallout from bundled plugin roots The strict knip workspaces landed in #108547 flagged seven files. Two are convention-resolved and become explicit entries (discord configured-state via the package-state probes, qa-lab cli via the SDK facade basename resolver); the other five were dead barrels/wrappers superseded by canonical modules and are deleted (browser bridge/cdp barrels, discord timeouts wrapper, openai register.runtime, qa-lab model-selection wrapper). --- config/knip.config.ts | 10 ++++++++-- extensions/browser/browser-bridge.ts | 6 ------ extensions/browser/browser-cdp.ts | 5 ----- extensions/discord/timeouts.ts | 7 ------- extensions/openai/register.runtime.ts | 12 ------------ extensions/qa-lab/model-selection.ts | 2 -- 6 files changed, 8 insertions(+), 34 deletions(-) delete mode 100644 extensions/browser/browser-bridge.ts delete mode 100644 extensions/browser/browser-cdp.ts delete mode 100644 extensions/discord/timeouts.ts delete mode 100644 extensions/openai/register.runtime.ts delete mode 100644 extensions/qa-lab/model-selection.ts diff --git a/config/knip.config.ts b/config/knip.config.ts index 4d6e7e9828a7..a35892e4bedb 100644 --- a/config/knip.config.ts +++ b/config/knip.config.ts @@ -397,7 +397,10 @@ const config = { [`${BUNDLED_PLUGIN_ROOT_DIR}/codex`]: strictBundledPluginWorkspace(), [`${BUNDLED_PLUGIN_ROOT_DIR}/deepgram`]: strictBundledPluginWorkspace(), [`${BUNDLED_PLUGIN_ROOT_DIR}/deepinfra`]: strictBundledPluginWorkspace(), - [`${BUNDLED_PLUGIN_ROOT_DIR}/discord`]: strictBundledPluginWorkspace(), + [`${BUNDLED_PLUGIN_ROOT_DIR}/discord`]: strictBundledPluginWorkspace([ + // Channel package-state probes resolve this module from package metadata. + "configured-state.ts!", + ]), [`${BUNDLED_PLUGIN_ROOT_DIR}/elevenlabs`]: strictBundledPluginWorkspace(), [`${BUNDLED_PLUGIN_ROOT_DIR}/featherless`]: strictBundledPluginWorkspace(), [`${BUNDLED_PLUGIN_ROOT_DIR}/fal`]: strictBundledPluginWorkspace(), @@ -424,7 +427,10 @@ const config = { [`${BUNDLED_PLUGIN_ROOT_DIR}/pixverse`]: strictBundledPluginWorkspace(), [`${BUNDLED_PLUGIN_ROOT_DIR}/qianfan`]: strictBundledPluginWorkspace(), [`${BUNDLED_PLUGIN_ROOT_DIR}/qwen`]: strictBundledPluginWorkspace(), - [`${BUNDLED_PLUGIN_ROOT_DIR}/qa-lab`]: strictBundledPluginWorkspace(), + [`${BUNDLED_PLUGIN_ROOT_DIR}/qa-lab`]: strictBundledPluginWorkspace([ + // The plugin-SDK QA Lab facade resolves this CLI surface by basename. + "cli.ts!", + ]), [`${BUNDLED_PLUGIN_ROOT_DIR}/senseaudio`]: strictBundledPluginWorkspace(), [`${BUNDLED_PLUGIN_ROOT_DIR}/tavily`]: strictBundledPluginWorkspace(), [`${BUNDLED_PLUGIN_ROOT_DIR}/tencent`]: strictBundledPluginWorkspace(), diff --git a/extensions/browser/browser-bridge.ts b/extensions/browser/browser-bridge.ts deleted file mode 100644 index 9a8961554d62..000000000000 --- a/extensions/browser/browser-bridge.ts +++ /dev/null @@ -1,6 +0,0 @@ -/** - * Browser bridge API barrel. It exposes the host/sandbox bridge server handle - * and lifecycle helpers without importing the full browser plugin entry. - */ -export type { BrowserBridge } from "./src/browser/bridge-server.js"; -export { startBrowserBridgeServer, stopBrowserBridgeServer } from "./src/browser/bridge-server.js"; diff --git a/extensions/browser/browser-cdp.ts b/extensions/browser/browser-cdp.ts deleted file mode 100644 index a4dccf5d1a2e..000000000000 --- a/extensions/browser/browser-cdp.ts +++ /dev/null @@ -1,5 +0,0 @@ -/** - * Browser CDP helper barrel. It exposes URL parsing/redaction helpers used by - * browser config and diagnostics surfaces. - */ -export { parseBrowserHttpUrl, redactCdpUrl } from "./src/browser/cdp.helpers.js"; diff --git a/extensions/discord/timeouts.ts b/extensions/discord/timeouts.ts deleted file mode 100644 index d3d6f2afb007..000000000000 --- a/extensions/discord/timeouts.ts +++ /dev/null @@ -1,7 +0,0 @@ -// Discord plugin module implements timeouts behavior. -export { - DISCORD_ATTACHMENT_IDLE_TIMEOUT_MS, - DISCORD_ATTACHMENT_TOTAL_TIMEOUT_MS, - DISCORD_DEFAULT_INBOUND_WORKER_TIMEOUT_MS, - DISCORD_DEFAULT_LISTENER_TIMEOUT_MS, -} from "./src/monitor/timeouts.js"; diff --git a/extensions/openai/register.runtime.ts b/extensions/openai/register.runtime.ts deleted file mode 100644 index 9568940d20ee..000000000000 --- a/extensions/openai/register.runtime.ts +++ /dev/null @@ -1,12 +0,0 @@ -// Openai plugin module implements register behavior. -export { buildOpenAIImageGenerationProvider } from "./image-generation-provider.js"; -export { openaiMediaUnderstandingProvider } from "./media-understanding-provider.js"; -export { buildOpenAIProvider } from "./openai-provider.js"; -export { - OPENAI_FRIENDLY_PROMPT_OVERLAY, - resolveOpenAIPromptOverlayMode, - shouldApplyOpenAIPromptOverlay, -} from "./prompt-overlay.js"; -export { buildOpenAIRealtimeTranscriptionProvider } from "./realtime-transcription-provider.js"; -export { buildOpenAIRealtimeVoiceProvider } from "./realtime-voice-provider.js"; -export { buildOpenAISpeechProvider } from "./speech-provider.js"; diff --git a/extensions/qa-lab/model-selection.ts b/extensions/qa-lab/model-selection.ts deleted file mode 100644 index dc1830036625..000000000000 --- a/extensions/qa-lab/model-selection.ts +++ /dev/null @@ -1,2 +0,0 @@ -// Qa Lab plugin module implements model selection behavior. -export * from "./src/model-selection.js";