diff --git a/src/security/audit-probe-failure.test.ts b/src/security/audit-probe-failure.test.ts index 9eb6dba9e62..cf2e4bb683e 100644 --- a/src/security/audit-probe-failure.test.ts +++ b/src/security/audit-probe-failure.test.ts @@ -1,6 +1,15 @@ import { describe, expect, it } from "vitest"; import { collectDeepProbeFindings } from "./audit-deep-probe-findings.js"; +function requireProbeFailure(findings: ReturnType) { + const finding = findings.find((entry) => entry.checkId === "gateway.probe_failed"); + expect(finding).toBeDefined(); + if (!finding) { + throw new Error("Expected gateway probe failure finding"); + } + return finding; +} + describe("security audit deep probe failure", () => { it("adds probe_failed warnings for deep probe failure modes", () => { const cases: Array<{ @@ -46,12 +55,8 @@ describe("security audit deep probe failure", () => { for (const testCase of cases) { const findings = collectDeepProbeFindings({ deep: testCase.deep }); - expect( - findings.some((finding) => finding.checkId === "gateway.probe_failed"), - testCase.name, - ).toBe(true); - const probeFailure = findings.find((finding) => finding.checkId === "gateway.probe_failed"); - expect(probeFailure?.detail, testCase.name).toContain(testCase.expectedError); + const probeFailure = requireProbeFailure(findings); + expect(probeFailure.detail, testCase.name).toContain(testCase.expectedError); } }); });