From 0dcc30b39cff85b2e5dfaf53c66b655adfc13737 Mon Sep 17 00:00:00 2001 From: Vincent Koc Date: Sun, 12 Apr 2026 09:28:20 +0100 Subject: [PATCH] test(zalouser): share default setup assertions --- extensions/zalouser/src/setup-surface.test.ts | 22 ++++++++++++------- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/extensions/zalouser/src/setup-surface.test.ts b/extensions/zalouser/src/setup-surface.test.ts index 77abf86716c..57c717a36e7 100644 --- a/extensions/zalouser/src/setup-surface.test.ts +++ b/extensions/zalouser/src/setup-surface.test.ts @@ -27,6 +27,18 @@ async function runSetup(params: { } describe("zalouser setup wizard", () => { + function expectEnabledDefaultSetup( + result: Awaited>, + dmPolicy?: "pairing" | "allowlist", + ) { + expect(result.accountId).toBe("default"); + expect(result.cfg.channels?.zalouser?.enabled).toBe(true); + expect(result.cfg.plugins?.entries?.zalouser?.enabled).toBe(true); + if (dmPolicy) { + expect(result.cfg.channels?.zalouser?.dmPolicy).toBe(dmPolicy); + } + } + function createQuickstartPrompter(params?: { note?: ReturnType["note"]; seen?: string[]; @@ -100,10 +112,7 @@ describe("zalouser setup wizard", () => { options: { quickstartDefaults: true }, }); - expect(result.accountId).toBe("default"); - expect(result.cfg.channels?.zalouser?.enabled).toBe(true); - expect(result.cfg.plugins?.entries?.zalouser?.enabled).toBe(true); - expect(result.cfg.channels?.zalouser?.dmPolicy).toBe("pairing"); + expectEnabledDefaultSetup(result, "pairing"); expect(seen.indexOf("Zalo Personal DM policy")).toBeGreaterThanOrEqual(0); expect(seen.indexOf("Configure Zalo groups access?")).toBeGreaterThanOrEqual(0); expect(seen.indexOf("Zalo Personal DM policy")).toBeLessThan( @@ -126,10 +135,7 @@ describe("zalouser setup wizard", () => { options: { quickstartDefaults: true }, }); - expect(result.accountId).toBe("default"); - expect(result.cfg.channels?.zalouser?.enabled).toBe(true); - expect(result.cfg.plugins?.entries?.zalouser?.enabled).toBe(true); - expect(result.cfg.channels?.zalouser?.dmPolicy).toBe("allowlist"); + expectEnabledDefaultSetup(result, "allowlist"); expect(result.cfg.channels?.zalouser?.allowFrom).toEqual([]); expect( note.mock.calls.some(([message]) => message.includes("No DM allowlist entries added yet.")),