chore: enable consistent-return

extensions/feishu/src/subagent-hooks.ts

@@ -270,16 +270,32 @@ type FeishuSubagentEndedEvent = {
   targetSessionKey: string;
 };
 
+type FeishuSubagentSpawningResult =
+  | { status: "ok"; threadBindingReady?: boolean }
+  | { status: "error"; error: string }
+  | undefined;
+
+type FeishuSubagentDeliveryTargetResult =
+  | {
+      origin: {
+        channel: "feishu";
+        accountId?: string;
+        to?: string;
+        threadId?: string | number;
+      };
+    }
+  | undefined;
+
 export async function handleFeishuSubagentSpawning(
   event: FeishuSubagentSpawningEvent,
   ctx: FeishuSubagentContext,
-) {
+): Promise<FeishuSubagentSpawningResult> {
   if (!event.threadRequested) {
-    return;
+    return undefined;
   }
   const requesterChannel = normalizeOptionalLowercaseString(event.requester?.channel);
   if (requesterChannel !== "feishu") {
-    return;
+    return undefined;
   }
 
   const manager = getFeishuThreadBindingManager(event.requester?.accountId);
@@ -341,13 +357,15 @@ export async function handleFeishuSubagentSpawning(
   }
 }
 
-export function handleFeishuSubagentDeliveryTarget(event: FeishuSubagentDeliveryTargetEvent) {
+export function handleFeishuSubagentDeliveryTarget(
+  event: FeishuSubagentDeliveryTargetEvent,
+): FeishuSubagentDeliveryTargetResult {
   if (!event.expectsCompletionMessage) {
-    return;
+    return undefined;
   }
   const requesterChannel = normalizeOptionalLowercaseString(event.requesterOrigin?.channel);
   if (requesterChannel !== "feishu") {
-    return;
+    return undefined;
   }
 
   const binding = resolveMatchingChildBinding({
@@ -360,7 +378,7 @@ export function handleFeishuSubagentDeliveryTarget(event: FeishuSubagentDelivery
     },
   });
   if (!binding) {
-    return;
+    return undefined;
   }
 
   return {