From 0ff793b9965e615e873dcd14b195a17c61e71cb9 Mon Sep 17 00:00:00 2001 From: Shakker Date: Fri, 8 May 2026 20:14:04 +0100 Subject: [PATCH] test: tighten slug generator runner assertions --- src/hooks/llm-slug-generator.test.ts | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/src/hooks/llm-slug-generator.test.ts b/src/hooks/llm-slug-generator.test.ts index 66b2be9a202..1e34ab6277a 100644 --- a/src/hooks/llm-slug-generator.test.ts +++ b/src/hooks/llm-slug-generator.test.ts @@ -22,6 +22,15 @@ vi.mock("../agents/pi-embedded.js", () => ({ import { generateSlugViaLLM } from "./llm-slug-generator.js"; +function requireFirstRunOptions(): unknown { + const options = runEmbeddedPiAgentMock.mock.calls[0]?.[0]; + expect(options).toBeDefined(); + if (!options) { + throw new Error("expected embedded Pi agent run options"); + } + return options; +} + describe("generateSlugViaLLM", () => { beforeEach(() => { runEmbeddedPiAgentMock.mockReset(); @@ -37,7 +46,7 @@ describe("generateSlugViaLLM", () => { }); expect(runEmbeddedPiAgentMock).toHaveBeenCalledOnce(); - expect(runEmbeddedPiAgentMock.mock.calls[0]?.[0]).toEqual( + expect(requireFirstRunOptions()).toEqual( expect.objectContaining({ timeoutMs: 15_000, cleanupBundleMcpOnRunEnd: true, @@ -58,7 +67,7 @@ describe("generateSlugViaLLM", () => { }); expect(runEmbeddedPiAgentMock).toHaveBeenCalledOnce(); - expect(runEmbeddedPiAgentMock.mock.calls[0]?.[0]).toEqual( + expect(requireFirstRunOptions()).toEqual( expect.objectContaining({ timeoutMs: 500_000, }), @@ -96,7 +105,7 @@ describe("generateSlugViaLLM", () => { }); expect(runEmbeddedPiAgentMock).toHaveBeenCalledOnce(); - expect(runEmbeddedPiAgentMock.mock.calls[0]?.[0]).toEqual( + expect(requireFirstRunOptions()).toEqual( expect.objectContaining({ provider: "openai-codex", model: "gpt-5.5",