From 127d698b68a0fb7987cca55a2b8c00a71f72c4de Mon Sep 17 00:00:00 2001 From: Peter Steinberger Date: Fri, 8 May 2026 20:58:54 +0100 Subject: [PATCH] test: tighten slack prepared message assertions --- .../monitor/message-handler/prepare.test.ts | 24 ++++++++++++------- 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/extensions/slack/src/monitor/message-handler/prepare.test.ts b/extensions/slack/src/monitor/message-handler/prepare.test.ts index e42b0c80ddc..c81b362f3c0 100644 --- a/extensions/slack/src/monitor/message-handler/prepare.test.ts +++ b/extensions/slack/src/monitor/message-handler/prepare.test.ts @@ -1981,10 +1981,12 @@ describe("prepareSlackMessage sender prefix", () => { const result = await prepareSenderPrefixMessage(ctx, "<@BOT> hello", "1700000000.0001"); - expect(result).not.toBeNull(); - const body = result?.ctxPayload.Body ?? ""; + if (!result) { + throw new Error("expected Slack sender prefix message"); + } + const body = result.ctxPayload.Body; expect(body).toContain("Alice (U1): <@BOT> (Bek) hello"); - expect(result?.ctxPayload.RawBody).toBe("<@BOT> (Bek) hello"); + expect(result.ctxPayload.RawBody).toBe("<@BOT> (Bek) hello"); }); it("keeps raw Slack mention tokens when user lookup cannot resolve them", async () => { @@ -1997,10 +1999,12 @@ describe("prepareSlackMessage sender prefix", () => { const result = await prepareSenderPrefixMessage(ctx, "<@BOT> hello", "1700000000.0001"); - expect(result).not.toBeNull(); - const body = result?.ctxPayload.Body ?? ""; + if (!result) { + throw new Error("expected Slack sender prefix message"); + } + const body = result.ctxPayload.Body; expect(body).toContain("Alice (U1): <@BOT> hello"); - expect(result?.ctxPayload.RawBody).toBe("<@BOT> hello"); + expect(result.ctxPayload.RawBody).toBe("<@BOT> hello"); }); it("caps Slack mention username lookups per inbound message and leaves overflow mentions raw", async () => { @@ -2183,7 +2187,9 @@ describe("slack thread.requireExplicitMention", () => { message, opts: { source: "message" }, }); - expect(result).not.toBeNull(); + if (!result) { + throw new Error("expected Slack thread reply message"); + } }); it("allows thread reply without explicit mention when requireExplicitMention is false (default)", async () => { @@ -2210,6 +2216,8 @@ describe("slack thread.requireExplicitMention", () => { message, opts: { source: "message" }, }); - expect(result).not.toBeNull(); + if (!result) { + throw new Error("expected Slack thread reply message"); + } }); });