From 16ff48c7290407580af2bb2efd30806020137d83 Mon Sep 17 00:00:00 2001 From: Peter Steinberger Date: Tue, 14 Jul 2026 09:13:50 +0100 Subject: [PATCH] refactor(time): trust pretty-ms defaults --- extensions/google-meet/src/cli.ts | 2 -- extensions/phone-control/index.ts | 1 - extensions/qa-lab/src/character-eval.ts | 2 -- extensions/qa-lab/web/src/ui-render-utils.ts | 2 -- extensions/qa-matrix/src/runners/contract/runtime.ts | 2 -- extensions/qqbot/src/engine/utils/format.ts | 2 -- scripts/build-all.mjs | 1 - scripts/run-additional-boundary-checks.mjs | 2 -- src/infra/format-time/format-duration.ts | 5 ++--- 9 files changed, 2 insertions(+), 17 deletions(-) diff --git a/extensions/google-meet/src/cli.ts b/extensions/google-meet/src/cli.ts index 1f5a091aceee..40ec2773c467 100644 --- a/extensions/google-meet/src/cli.ts +++ b/extensions/google-meet/src/cli.ts @@ -346,8 +346,6 @@ function formatDuration(value: number | undefined): string { return "n/a"; } return prettyMilliseconds(Math.max(0, Math.round(value / 1000) * 1000), { - millisecondsDecimalDigits: 0, - secondsDecimalDigits: 0, unitCount: 2, }); } diff --git a/extensions/phone-control/index.ts b/extensions/phone-control/index.ts index 3c1fc4783623..de50188141c3 100644 --- a/extensions/phone-control/index.ts +++ b/extensions/phone-control/index.ts @@ -108,7 +108,6 @@ function formatDuration(ms: number): string { return prettyMilliseconds(Math.max(0, roundedMs), { compact: true, hideYear: true, - secondsDecimalDigits: 0, }); } diff --git a/extensions/qa-lab/src/character-eval.ts b/extensions/qa-lab/src/character-eval.ts index 56b8398cf579..f60b50f46ace 100644 --- a/extensions/qa-lab/src/character-eval.ts +++ b/extensions/qa-lab/src/character-eval.ts @@ -243,8 +243,6 @@ function formatDuration(ms: number) { } const roundedMs = ms < 1000 ? Math.round(ms) : Math.round(ms / 1000) * 1000; return prettyMilliseconds(roundedMs, { - millisecondsDecimalDigits: 0, - secondsDecimalDigits: 0, unitCount: 2, }); } diff --git a/extensions/qa-lab/web/src/ui-render-utils.ts b/extensions/qa-lab/web/src/ui-render-utils.ts index 4f15e64e37db..bf72eea52187 100644 --- a/extensions/qa-lab/web/src/ui-render-utils.ts +++ b/extensions/qa-lab/web/src/ui-render-utils.ts @@ -24,8 +24,6 @@ export function formatIso(iso?: string) { export function formatDuration(ms: number): string { const roundedMs = ms < 1000 ? Math.round(ms) : Math.round(ms / 1000) * 1000; return prettyMilliseconds(Math.max(0, roundedMs), { - millisecondsDecimalDigits: 0, - secondsDecimalDigits: 0, unitCount: 2, }); } diff --git a/extensions/qa-matrix/src/runners/contract/runtime.ts b/extensions/qa-matrix/src/runners/contract/runtime.ts index c4c0f88b8d70..1671889ce40c 100644 --- a/extensions/qa-matrix/src/runners/contract/runtime.ts +++ b/extensions/qa-matrix/src/runners/contract/runtime.ts @@ -193,8 +193,6 @@ function shouldWriteMatrixQaProgress() { function formatMatrixQaDurationMs(durationMs: number) { const roundedMs = durationMs < 1000 ? Math.round(durationMs) : Math.round(durationMs / 100) * 100; return prettyMilliseconds(Math.max(0, roundedMs), { - millisecondsDecimalDigits: 0, - secondsDecimalDigits: 1, unitCount: 1, }); } diff --git a/extensions/qqbot/src/engine/utils/format.ts b/extensions/qqbot/src/engine/utils/format.ts index acab411cead8..500e559b7265 100644 --- a/extensions/qqbot/src/engine/utils/format.ts +++ b/extensions/qqbot/src/engine/utils/format.ts @@ -65,8 +65,6 @@ export function formatDuration(durationMs: number): string { const roundedMs = durationMs < 1000 ? Math.round(durationMs) : Math.round(durationMs / 1000) * 1000; return prettyMilliseconds(roundedMs, { - millisecondsDecimalDigits: 0, - secondsDecimalDigits: 0, unitCount: 2, }); } diff --git a/scripts/build-all.mjs b/scripts/build-all.mjs index 8b8941888151..e2f77e1f636c 100644 --- a/scripts/build-all.mjs +++ b/scripts/build-all.mjs @@ -594,7 +594,6 @@ export function formatBuildAllDuration(durationMs) { ? Math.round(clampedMs / 10) * 10 : Math.round(clampedMs / 100) * 100; return prettyMilliseconds(roundedMs, { - millisecondsDecimalDigits: 0, secondsDecimalDigits: clampedMs < 10_000 ? 2 : 1, }); } diff --git a/scripts/run-additional-boundary-checks.mjs b/scripts/run-additional-boundary-checks.mjs index 9298c8922898..bd903c253e4f 100644 --- a/scripts/run-additional-boundary-checks.mjs +++ b/scripts/run-additional-boundary-checks.mjs @@ -449,8 +449,6 @@ function formatDuration(ms) { } const roundedMs = ms < 1000 ? Math.round(ms) : Math.round(ms / 100) * 100; return prettyMilliseconds(Math.max(0, roundedMs), { - millisecondsDecimalDigits: 0, - secondsDecimalDigits: 1, unitCount: 1, }); } diff --git a/src/infra/format-time/format-duration.ts b/src/infra/format-time/format-duration.ts index 4c7520628373..2bd1af432a88 100644 --- a/src/infra/format-time/format-duration.ts +++ b/src/infra/format-time/format-duration.ts @@ -38,7 +38,7 @@ export function formatDurationPrecise( } const roundedMs = Math.max(0, Math.round(ms)); if (roundedMs < 1000) { - return prettyMilliseconds(roundedMs, { millisecondsDecimalDigits: 0 }); + return prettyMilliseconds(roundedMs); } return formatDurationSeconds(ms, { decimals: options.decimals ?? 2, @@ -61,11 +61,10 @@ export function formatDurationCompact( } const roundedMs = Math.round(ms); if (roundedMs < 1000) { - return prettyMilliseconds(roundedMs, { millisecondsDecimalDigits: 0 }); + return prettyMilliseconds(roundedMs); } const formatted = prettyMilliseconds(Math.round(ms / 1000) * 1000, { hideYear: true, - secondsDecimalDigits: 0, unitCount: 2, }); return options?.spaced ? formatted : formatted.replaceAll(" ", "");