vultr/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-05-06 16:10:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Found one bug in the new compile-cache prune path: it removes a d (#74067)

Browse Source 
* fix: Found one bug in the new compile-cache prune path: it removes a d

* fix(postinstall): keep compile cache pruning resilient

---------

Co-authored-by: openclaw-clownfish[bot] <280122609+openclaw-clownfish[bot]@users.noreply.github.com>
Co-authored-by: Vincent Koc <vincentkoc@ieee.org>
This commit is contained in:
openclaw-clownfish[bot]
2026-04-29 01:12:59 -07:00
committed by GitHub
parent 4d43daa7bb
commit 1a936f225e
2 changed files with 80 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

73
test/scripts/postinstall-bundled-plugins.test.ts
View File

@@ -1,4 +1,5 @@
import fs from "node:fs/promises";
import { tmpdir } from "node:os";
import path from "node:path";
import { describe, expect, it, vi } from "vitest";
import {
@@ -181,29 +182,79 @@ describe("bundled plugin postinstall", () => {
expect(spawnSync).not.toHaveBeenCalled();
});
it("prunes OpenClaw compile cache during package postinstall", () => {
it("prunes Node versioned compile cache dirs during package postinstall", () => {
const configuredBase = path.join("/tmp", "openclaw-cache");
const defaultBase = path.join(tmpdir(), "node-compile-cache");
const removed: string[] = [];
const existsSync = vi.fn((value: string) =>
value.endsWith(path.join("openclaw-cache", "openclaw")),
);
const existsSync = vi.fn((value: string) => value === configuredBase || value === defaultBase);
const readdirSync = vi.fn((value: string) => {
if (value === configuredBase) {
return [
{ name: "v22.13.1-x64-efe9a9df-1001", isDirectory: () => true },
{ name: "openclaw", isDirectory: () => true },
{ name: "README", isDirectory: () => false },
];
}
if (value === defaultBase) {
return [{ name: "v24.14.1-x64-efe9a9df-1001", isDirectory: () => true }];
}
throw new Error(`unexpected readdir: ${value}`);
});
const rmSync = vi.fn((value: string) => {
removed.push(value);
});
pruneOpenClawCompileCache({
env: { NODE_COMPILE_CACHE: path.join("/tmp", "openclaw-cache") },
env: { NODE_COMPILE_CACHE: configuredBase },
existsSync,
readdirSync,
rmSync,
log: { warn: vi.fn() },
});
expect(removed).toEqual([path.join("/tmp", "openclaw-cache", "openclaw")]);
expect(rmSync).toHaveBeenCalledWith(path.join("/tmp", "openclaw-cache", "openclaw"), {
recursive: true,
force: true,
maxRetries: 2,
retryDelay: 100,
expect(removed).toEqual([
path.join(configuredBase, "v22.13.1-x64-efe9a9df-1001"),
path.join(defaultBase, "v24.14.1-x64-efe9a9df-1001"),
]);
expect(removed).not.toContain(path.join(configuredBase, "openclaw"));
for (const cacheDir of removed) {
expect(rmSync).toHaveBeenCalledWith(cacheDir, {
recursive: true,
force: true,
maxRetries: 2,
retryDelay: 100,
});
}
});
it("keeps pruning sibling compile cache dirs after one removal fails", () => {
const configuredBase = path.join("/tmp", "openclaw-cache");
const attempted: string[] = [];
const warn = vi.fn();
const firstCacheDir = path.join(configuredBase, "v22.13.1-x64-efe9a9df-1001");
const secondCacheDir = path.join(configuredBase, "v22.13.1-x64-efe9a9df-1002");
const rmSync = vi.fn((value: string) => {
attempted.push(value);
if (value === firstCacheDir) {
throw new Error("locked");
}
});
pruneOpenClawCompileCache({
env: { NODE_COMPILE_CACHE: configuredBase },
existsSync: vi.fn((value: string) => value === configuredBase),
readdirSync: vi.fn(() => [
{ name: path.basename(firstCacheDir), isDirectory: () => true },
{ name: path.basename(secondCacheDir), isDirectory: () => true },
]),
rmSync,
log: { warn },
});
expect(attempted).toEqual([firstCacheDir, secondCacheDir]);
expect(warn).toHaveBeenCalledWith(
"[postinstall] could not prune OpenClaw compile cache: Error: locked",
);
});
it("prunes source-checkout bundled plugin node_modules", async () => {