fix(matrix): bind approval reactions before option emoji

extensions/matrix/src/approval-handler.runtime.test.ts

@@ -266,6 +266,52 @@ describe("matrixApprovalNativeRuntime", () => {
     );
   });
 
+  it("binds Matrix approval reactions before publishing option reactions", async () => {
+    const sendSingleTextMessage = vi.fn().mockResolvedValue({
+      messageId: "$approval",
+      primaryMessageId: "$approval",
+      messageIds: ["$approval"],
+      roomId: "!room:example.org",
+    });
+    const reactMessage = vi.fn().mockImplementation(async () => {
+      expect(
+        resolveMatrixApprovalReactionTarget({
+          roomId: "!room:example.org",
+          eventId: "$approval",
+          reactionKey: "✅",
+        }),
+      ).toEqual({
+        approvalId: "req-1",
+        decision: "allow-once",
+      });
+    });
+    const view = buildExecApprovalView();
+    const pendingPayload = await buildPendingPayload(view);
+
+    await matrixApprovalNativeRuntime.transport.deliverPending({
+      cfg: {} as never,
+      accountId: "default",
+      context: {
+        client: {} as never,
+        deps: {
+          sendSingleTextMessage,
+          reactMessage,
+        },
+      },
+      request: {} as never,
+      approvalKind: "exec",
+      plannedTarget: buildMatrixApprovalRoomTarget("!room:example.org"),
+      preparedTarget: {
+        to: "room:!room:example.org",
+        roomId: "!room:example.org",
+      },
+      view,
+      pendingPayload,
+    });
+
+    expect(reactMessage).toHaveBeenCalled();
+  });
+
   it("falls back to chunked Matrix delivery when approval content exceeds one event", async () => {
     const sendSingleTextMessage = vi
       .fn()

extensions/matrix/src/approval-handler.runtime.ts

@@ -408,7 +408,7 @@ export const matrixApprovalNativeRuntime = createChannelApprovalNativeRuntimeAda
           : null,
       );
     },
-    deliverPending: async ({ cfg, accountId, context, preparedTarget, pendingPayload }) => {
+    deliverPending: async ({ cfg, accountId, context, preparedTarget, pendingPayload, view }) => {
       const resolved = resolveHandlerContext({ cfg, accountId, context });
       if (!resolved) {
         return null;
@@ -447,6 +447,13 @@ export const matrixApprovalNativeRuntime = createChannelApprovalNativeRuntimeAda
       );
       const reactionEventId =
         result.primaryMessageId?.trim() || messageIds[0] || result.messageId.trim();
+      registerMatrixApprovalReactionTarget({
+        roomId: result.roomId,
+        eventId: reactionEventId,
+        approvalId: pendingPayload.approvalId,
+        allowedDecisions: pendingPayload.allowedDecisions,
+        ttlMs: view.expiresAtMs - Date.now(),
+      });
       await Promise.allSettled(
         listMatrixApprovalReactionBindings(pendingPayload.allowedDecisions).map(
           async ({ emoji }) => {