From 1dd8a88d218d464a4dbc191afbb0acdbd8f1cf02 Mon Sep 17 00:00:00 2001 From: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Date: Sat, 23 May 2026 23:46:56 +0000 Subject: [PATCH] fix(clawsweeper): address review for automerge-openclaw-openclaw-84878 (validation-1) --- extensions/meeting-notes/index.test.ts | 8 ++++++-- extensions/meeting-notes/src/tool.ts | 2 +- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/extensions/meeting-notes/index.test.ts b/extensions/meeting-notes/index.test.ts index 7b05440a8e1..3b5c40121b2 100644 --- a/extensions/meeting-notes/index.test.ts +++ b/extensions/meeting-notes/index.test.ts @@ -429,15 +429,19 @@ describe("meeting-notes plugin", () => { ], }); const logger = { debug: vi.fn(), error: vi.fn(), info: vi.fn(), warn: vi.fn() }; + const service = services[0]; + if (!service?.stop) { + throw new Error("Expected meeting notes service with stop hook"); + } - await services[0]?.start({ config: {}, logger, stateDir }); + await service.start({ config: {}, logger, stateDir }); await vi.waitFor(() => { expect(start).toHaveBeenCalledOnce(); }); const request = start.mock.calls[0]?.[0]; expect(request.abortSignal?.aborted).toBe(false); - await services[0]?.stop({ config: {}, logger, stateDir }); + await service.stop({ config: {}, logger, stateDir }); expect(request.abortSignal?.aborted).toBe(true); expect(stop).not.toHaveBeenCalled(); diff --git a/extensions/meeting-notes/src/tool.ts b/extensions/meeting-notes/src/tool.ts index c15ae11779f..6bf8d476a18 100644 --- a/extensions/meeting-notes/src/tool.ts +++ b/extensions/meeting-notes/src/tool.ts @@ -106,7 +106,7 @@ async function waitForPendingAutoStartsToSettle( let timeout: ReturnType | undefined; try { return await Promise.race([ - Promise.allSettled([...pendingStarts]).then(() => true), + Promise.allSettled(pendingStarts).then(() => true), new Promise((resolve) => { timeout = setTimeout(() => resolve(false), AUTO_START_STOP_TIMEOUT_MS); timeout.unref?.();