From 1ecc1e899e2b28222cc1236a204e6599558e0015 Mon Sep 17 00:00:00 2001
From: Peter Steinberger <steipete@gmail.com>
Date: Fri, 8 May 2026 17:42:21 +0100
Subject: [PATCH] test: require active secrets snapshot

---
 src/secrets/runtime-auth-refresh-failure.test.ts | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/src/secrets/runtime-auth-refresh-failure.test.ts b/src/secrets/runtime-auth-refresh-failure.test.ts
index 3e119233c27..793e6a2a063 100644
--- a/src/secrets/runtime-auth-refresh-failure.test.ts
+++ b/src/secrets/runtime-auth-refresh-failure.test.ts
@@ -20,6 +20,16 @@ import {
 
 vi.unmock("../version.js");
 
+function expectActiveSecretsRuntimeSnapshot(): NonNullable<
+  ReturnType<typeof getActiveSecretsRuntimeSnapshot>
+> {
+  const snapshot = getActiveSecretsRuntimeSnapshot();
+  if (snapshot === null) {
+    throw new Error("Expected active secrets runtime snapshot");
+  }
+  return snapshot;
+}
+
 describe("secrets runtime snapshot auth refresh failure", () => {
   let envSnapshot: SecretsRuntimeEnvSnapshot;
 
@@ -75,10 +85,9 @@ describe("secrets runtime snapshot auth refresh failure", () => {
         }),
       ).rejects.toThrow(/simulated secrets runtime refresh failure/i);
 
-      const activeAfterFailure = getActiveSecretsRuntimeSnapshot();
-      expect(activeAfterFailure).not.toBeNull();
+      const activeAfterFailure = expectActiveSecretsRuntimeSnapshot();
       expectResolvedOpenAIRuntime(agentDir);
-      expect(activeAfterFailure?.sourceConfig.models?.providers?.openai?.apiKey).toEqual(
+      expect(activeAfterFailure.sourceConfig.models?.providers?.openai?.apiKey).toEqual(
         OPENAI_FILE_KEY_REF,
       );
     });