test: expand codex image fallback coverage (#65061) (thanks @zhulijin1991)

extensions/codex/src/app-server/run-attempt.vision-tools.test.ts

@@ -4,17 +4,31 @@ import { __testing } from "./run-attempt.js";
 describe("Codex dynamic tool filtering", () => {
   it("drops the image tool when the model already has inbound vision input", () => {
     const toolNames = __testing
-      .filterToolsForVisionInputs(
-        [{ name: "image" }, { name: "read" }, { name: "write" }],
-        {
-          modelHasVision: true,
-          hasInboundImages: true,
-        },
-      )
+      .filterToolsForVisionInputs([{ name: "image" }, { name: "read" }, { name: "write" }], {
+        modelHasVision: true,
+        hasInboundImages: true,
+      })
       .map((tool) => tool.name);
 
     expect(toolNames).toContain("read");
     expect(toolNames).toContain("write");
     expect(toolNames).not.toContain("image");
   });
+
+  it("keeps the image tool unless both model vision and inbound images are present", () => {
+    const tools = [{ name: "image" }, { name: "read" }];
+
+    expect(
+      __testing.filterToolsForVisionInputs(tools, {
+        modelHasVision: false,
+        hasInboundImages: true,
+      }),
+    ).toBe(tools);
+    expect(
+      __testing.filterToolsForVisionInputs(tools, {
+        modelHasVision: true,
+        hasInboundImages: false,
+      }),
+    ).toBe(tools);
+  });
 });