chore(lint): enable no-promise-executor-return

This commit is contained in:
Peter Steinberger
2026-05-31 23:06:03 +01:00
parent 48afba96a3
commit 22cb7fb6b7
375 changed files with 2134 additions and 884 deletions

View File

@@ -28,7 +28,9 @@ describe("E2E WebSocket open guard", () => {
} finally {
clearTimeout(keepAlive);
}
await new Promise((resolve) => setImmediate(resolve));
await new Promise((resolve) => {
setImmediate(resolve);
});
expect(ws.terminated).toBe(true);
expect(ws.listenerCount("open")).toBe(0);

View File

@@ -779,7 +779,7 @@ describe("kitchen-sink RPC process sampling", () => {
const fetchImpl = vi.fn().mockResolvedValue({
ok: true,
status: 200,
text: () => new Promise(() => undefined),
text: () => new Promise(() => {}),
});
const result = fetchJson("http://127.0.0.1:19680/readyz", {

View File

@@ -23,7 +23,7 @@ describe("MCP stdio connect timeout", () => {
it("closes the transport when MCP initialize hangs", async () => {
vi.useFakeTimers();
const client = {
connect: vi.fn(() => new Promise<void>(() => undefined)),
connect: vi.fn(() => new Promise<void>(() => {})),
};
const transport = {
close: vi.fn(),
@@ -41,7 +41,7 @@ describe("MCP stdio connect timeout", () => {
vi.useFakeTimers();
let closeSettled = false;
const client = {
connect: vi.fn(() => new Promise<void>(() => undefined)),
connect: vi.fn(() => new Promise<void>(() => {})),
};
const transport = {
close: vi.fn(
@@ -70,7 +70,7 @@ describe("MCP stdio connect timeout", () => {
it("keeps the original timeout error when cleanup rejects", async () => {
vi.useFakeTimers();
const client = {
connect: vi.fn(() => new Promise<void>(() => undefined)),
connect: vi.fn(() => new Promise<void>(() => {})),
};
const transport = {
close: vi.fn(async () => {

View File

@@ -33,7 +33,9 @@ describe("mcp channel WebSocket open guard", () => {
} finally {
clearTimeout(keepAlive);
}
await new Promise((resolve) => setImmediate(resolve));
await new Promise((resolve) => {
setImmediate(resolve);
});
expect(ws.terminated).toBe(true);
expect(ws.listenerCount("open")).toBe(0);

View File

@@ -731,7 +731,9 @@ describe("scripts/openclaw-cross-os-release-checks", () => {
}),
]);
await Promise.race([
new Promise<void>((resolve) => socket.once("close", resolve)),
new Promise<void>((resolve) => {
socket.once("close", resolve);
}),
delay(1_000).then(() => {
throw new Error("socket close timed out");
}),

View File

@@ -20,7 +20,9 @@ function isProcessAlive(pid: number): boolean {
}
async function sleep(ms: number): Promise<void> {
await new Promise((resolve) => setTimeout(resolve, ms));
await new Promise((resolve) => {
setTimeout(resolve, ms);
});
}
async function waitForFile(filePath: string, timeoutMs: number): Promise<void> {

View File

@@ -105,11 +105,13 @@ function withEnv<T>(env: Record<string, string>, callback: () => T): T {
async function unusedLoopbackPort(): Promise<number> {
const server = createServer();
await new Promise<void>((resolve) => server.listen(0, "127.0.0.1", resolve));
await new Promise<void>((resolve) => {
server.listen(0, "127.0.0.1", resolve);
});
const address = server.address();
await new Promise<void>((resolve, reject) =>
server.close((error) => (error ? reject(error) : resolve())),
);
await new Promise<void>((resolve, reject) => {
server.close((error) => (error ? reject(error) : resolve()));
});
if (!address || typeof address === "string") {
throw new Error("Expected TCP server address.");
}

View File

@@ -54,7 +54,10 @@ describe("Parallels update job timeout", () => {
const result = runTimedUpdateJob({
append: (chunk) => chunks.push(chunk),
label: "macOS",
run: () => new Promise<void>((resolve) => setTimeout(resolve, 1000)),
run: () =>
new Promise<void>((resolve) => {
setTimeout(resolve, 1000);
}),
timeoutDescription: "1s plus cleanup backstop",
timeoutMs: 1200,
writeLog,
@@ -74,7 +77,7 @@ describe("Parallels update job timeout", () => {
const result = runTimedUpdateJob({
append: (chunk) => chunks.push(chunk),
label: "Windows",
run: () => new Promise(() => undefined),
run: () => new Promise(() => {}),
timeoutDescription: "1s",
timeoutMs: 1000,
writeLog,

View File

@@ -568,7 +568,9 @@ describe("plugin gateway gauntlet helpers", () => {
expect(row.spawnError?.code).toBe("ETIMEDOUT");
expect(row.wallMs).toBeLessThan(5_000);
const afterReturn = await fs.readFile(markerPath, "utf8");
await new Promise((resolve) => setTimeout(resolve, 250));
await new Promise((resolve) => {
setTimeout(resolve, 250);
});
await expect(fs.readFile(markerPath, "utf8")).resolves.toBe(afterReturn);
});

View File

@@ -60,7 +60,9 @@ async function startTcpFixtureServer(handler: (socket: Socket) => void): Promise
socket.on("error", () => undefined);
socket.on("close", () => sockets.delete(socket));
});
await new Promise<void>((resolve) => server.listen(0, "127.0.0.1", resolve));
await new Promise<void>((resolve) => {
server.listen(0, "127.0.0.1", resolve);
});
const address = server.address() as AddressInfo;
return {
port: address.port,
@@ -68,9 +70,9 @@ async function startTcpFixtureServer(handler: (socket: Socket) => void): Promise
for (const socket of sockets) {
socket.destroy();
}
await new Promise<void>((resolve, reject) =>
server.close((error) => (error ? reject(error) : resolve())),
);
await new Promise<void>((resolve, reject) => {
server.close((error) => (error ? reject(error) : resolve()));
});
},
};
}

View File

@@ -33,7 +33,9 @@ describe("source file scan cache", () => {
const readFile = async (filePath: string) => {
activeReads += 1;
maxActiveReads = Math.max(maxActiveReads, activeReads);
await new Promise((resolve) => setTimeout(resolve, 10));
await new Promise((resolve) => {
setTimeout(resolve, 10);
});
activeReads -= 1;
return `content:${path.basename(filePath)}`;
};

View File

@@ -576,7 +576,9 @@ describe("scripts/test-extension.mjs", () => {
await Promise.resolve();
expect(started).toEqual(["heavy", "middle"]);
resolvers.shift()?.();
await new Promise<void>((resolve) => setImmediate(resolve));
await new Promise<void>((resolve) => {
setImmediate(resolve);
});
expect(started).toEqual(["heavy", "middle", "light"]);
while (resolvers.length > 0) {
resolvers.shift()?.();

View File

@@ -56,7 +56,9 @@ describe("write-cli-startup-metadata", () => {
const result = await __testing.mapWithConcurrency([1, 2, 3, 4, 5], 2, async (value) => {
active += 1;
peakActive = Math.max(peakActive, active);
await new Promise((resolve) => setTimeout(resolve, 1));
await new Promise((resolve) => {
setTimeout(resolve, 1);
});
active -= 1;
return `rendered-${value}`;
});