From 247fed1ca9a8bfce7f83bf91acd0026d0f355bba Mon Sep 17 00:00:00 2001 From: Peter Steinberger Date: Fri, 8 May 2026 22:35:47 +0100 Subject: [PATCH] test: dedupe import boundary file checks --- test/plugin-extension-import-boundary.test.ts | 37 ++++++++++++------- 1 file changed, 23 insertions(+), 14 deletions(-) diff --git a/test/plugin-extension-import-boundary.test.ts b/test/plugin-extension-import-boundary.test.ts index c447b597f15..5d490da0801 100644 --- a/test/plugin-extension-import-boundary.test.ts +++ b/test/plugin-extension-import-boundary.test.ts @@ -17,29 +17,38 @@ const baselinePath = path.join( ); const baseline = JSON.parse(readFileSync(baselinePath, "utf8")); +function collectInventoryFiles( + inventory: Awaited>, + predicate: (file: string) => boolean, +): string[] { + const files: string[] = []; + for (const entry of inventory) { + if (predicate(entry.file)) { + files.push(entry.file); + } + } + return files; +} + describe("plugin extension import boundary inventory", () => { it("keeps dedicated web-search registry shims out of the remaining inventory", async () => { const inventory = await collectPluginExtensionImportBoundaryInventory(); - const blockedShimFiles = inventory - .filter( - (entry) => - entry.file === "src/plugins/web-search-providers.ts" || - entry.file === "src/plugins/bundled-web-search-registry.ts", - ) - .map((entry) => entry.file); + const blockedShimFiles = collectInventoryFiles( + inventory, + (file) => + file === "src/plugins/web-search-providers.ts" || + file === "src/plugins/bundled-web-search-registry.ts", + ); expect(blockedShimFiles).toEqual([]); }); it("ignores boundary shims by scope", async () => { const inventory = await collectPluginExtensionImportBoundaryInventory(); - const boundaryShimFiles = inventory - .filter( - (entry) => - entry.file.startsWith("src/plugin-sdk/") || - entry.file.startsWith("src/plugin-sdk-internal/"), - ) - .map((entry) => entry.file); + const boundaryShimFiles = collectInventoryFiles( + inventory, + (file) => file.startsWith("src/plugin-sdk/") || file.startsWith("src/plugin-sdk-internal/"), + ); expect(boundaryShimFiles).toEqual([]); });