From 2940379361b34977c2abb502565cf2167fa5f8bd Mon Sep 17 00:00:00 2001
From: Peter Steinberger <steipete@gmail.com>
Date: Fri, 10 Apr 2026 20:00:58 +0100
Subject: [PATCH] chore: enable no-unnecessary-template-expression

---
 .oxlintrc.json                                       | 1 -
 extensions/google/oauth.test.ts                      | 2 +-
 extensions/whatsapp/src/channel-react-action.test.ts | 2 +-
 extensions/whatsapp/src/channel.setup.test.ts        | 2 +-
 extensions/whatsapp/src/heartbeat-recipients.test.ts | 2 +-
 5 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/.oxlintrc.json b/.oxlintrc.json
index c1eecf3d1bc..7037f292991 100644
--- a/.oxlintrc.json
+++ b/.oxlintrc.json
@@ -63,7 +63,6 @@
         "typescript/no-explicit-any": "off",
         "typescript/no-floating-promises": "off",
         "typescript/no-redundant-type-constituents": "off",
-        "typescript/no-unnecessary-template-expression": "off",
         "typescript/unbound-method": "off",
         "eslint/no-unsafe-optional-chaining": "off"
       }
diff --git a/extensions/google/oauth.test.ts b/extensions/google/oauth.test.ts
index 44196a9af24..c6b6b4a259f 100644
--- a/extensions/google/oauth.test.ts
+++ b/extensions/google/oauth.test.ts
@@ -607,7 +607,7 @@ describe("loginGeminiCliOAuth", () => {
       note: async () => {},
       prompt: async () => {
         const state = new URL(authUrl).searchParams.get("state");
-        return `${"http://localhost:8085/oauth2callback"}?code=oauth-code&state=${state}`;
+        return `http://localhost:8085/oauth2callback?code=oauth-code&state=${state}`;
       },
       progress: { update: () => {}, stop: () => {} },
     });
diff --git a/extensions/whatsapp/src/channel-react-action.test.ts b/extensions/whatsapp/src/channel-react-action.test.ts
index aff2e787057..e458293ab81 100644
--- a/extensions/whatsapp/src/channel-react-action.test.ts
+++ b/extensions/whatsapp/src/channel-react-action.test.ts
@@ -17,7 +17,7 @@ vi.mock("./channel-react-action.runtime.js", async () => {
       toolContext?: { currentMessageId?: string | number | null };
     }) => args.messageId ?? toolContext?.currentMessageId ?? null,
     normalizeWhatsAppTarget: (value?: string | null) => {
-      const raw = `${value ?? ""}`.trim();
+      const raw = (value ?? "").trim();
       if (!raw) {
         return null;
       }
diff --git a/extensions/whatsapp/src/channel.setup.test.ts b/extensions/whatsapp/src/channel.setup.test.ts
index 9c6fc60d991..5bc5dc4d439 100644
--- a/extensions/whatsapp/src/channel.setup.test.ts
+++ b/extensions/whatsapp/src/channel.setup.test.ts
@@ -39,7 +39,7 @@ vi.mock("openclaw/plugin-sdk/setup", async () => {
     "openclaw/plugin-sdk/setup",
   );
   const normalizeE164 = (value?: string | null) => {
-    const raw = `${value ?? ""}`.trim();
+    const raw = (value ?? "").trim();
     if (!raw) {
       return "";
     }
diff --git a/extensions/whatsapp/src/heartbeat-recipients.test.ts b/extensions/whatsapp/src/heartbeat-recipients.test.ts
index 1303f286ad4..e9a44610b3a 100644
--- a/extensions/whatsapp/src/heartbeat-recipients.test.ts
+++ b/extensions/whatsapp/src/heartbeat-recipients.test.ts
@@ -15,7 +15,7 @@ vi.mock("./heartbeat-recipients.runtime.js", () => ({
     return trimmed ? (trimmed as "whatsapp") : null;
   },
   normalizeE164: (value?: string | null) => {
-    const digits = `${value ?? ""}`.replace(/[^\d+]/g, "");
+    const digits = (value ?? "").replace(/[^\d+]/g, "");
     if (!digits) {
       return "";
     }