refactor(matrix): reuse shared sync lifecycle checks

This commit is contained in:
Gustavo Madeira Santana
2026-04-07 23:43:19 -04:00
parent c0397d5cc8
commit 2b93b369ff
2 changed files with 2 additions and 10 deletions

View File

@@ -91,8 +91,6 @@ function deleteSharedClientState(state: SharedMatrixClientState): void {
async function ensureSharedClientStarted(params: {
state: SharedMatrixClientState;
timeoutMs?: number;
initialSyncLimit?: number;
encryption?: boolean;
abortSignal?: AbortSignal;
}): Promise<void> {
@@ -170,8 +168,6 @@ async function resolveSharedMatrixClientState(
if (shouldStart) {
await ensureSharedClientStarted({
state: existingState,
timeoutMs: params.timeoutMs,
initialSyncLimit: auth.initialSyncLimit,
encryption: auth.encryption,
abortSignal: params.abortSignal,
});
@@ -185,8 +181,6 @@ async function resolveSharedMatrixClientState(
if (shouldStart) {
await ensureSharedClientStarted({
state: pending,
timeoutMs: params.timeoutMs,
initialSyncLimit: auth.initialSyncLimit,
encryption: auth.encryption,
abortSignal: params.abortSignal,
});
@@ -206,8 +200,6 @@ async function resolveSharedMatrixClientState(
if (shouldStart) {
await ensureSharedClientStarted({
state: created,
timeoutMs: params.timeoutMs,
initialSyncLimit: auth.initialSyncLimit,
encryption: auth.encryption,
abortSignal: params.abortSignal,
});

View File

@@ -1,5 +1,5 @@
import type { MatrixClient } from "../sdk.js";
import type { MatrixSyncState } from "../sync-state.js";
import { isMatrixTerminalSyncState, type MatrixSyncState } from "../sync-state.js";
import type { MatrixMonitorStatusController } from "./status.js";
function formatSyncLifecycleError(state: MatrixSyncState, error?: unknown): Error {
@@ -37,7 +37,7 @@ export function createMatrixMonitorSyncLifecycle(params: {
const onSyncState = (state: MatrixSyncState, _prevState: string | null, error?: unknown) => {
params.statusController.noteSyncState(state, error);
if (state === "STOPPED" && !params.isStopping?.()) {
if (isMatrixTerminalSyncState(state) && !params.isStopping?.()) {
settleFatal(formatSyncLifecycleError(state, error));
}
};