From 2c7c57d5197bd7e6e93104f72fd5c67c8264e9fb Mon Sep 17 00:00:00 2001
From: Peter Steinberger <steipete@gmail.com>
Date: Fri, 8 May 2026 08:58:25 +0100
Subject: [PATCH] test: clarify feishu validation assertions

---
 extensions/feishu/src/config-schema.test.ts  |  4 +---
 extensions/feishu/src/security-audit.test.ts | 10 ++++------
 2 files changed, 5 insertions(+), 9 deletions(-)

diff --git a/extensions/feishu/src/config-schema.test.ts b/extensions/feishu/src/config-schema.test.ts
index 9477925f561..2656f723a22 100644
--- a/extensions/feishu/src/config-schema.test.ts
+++ b/extensions/feishu/src/config-schema.test.ts
@@ -315,9 +315,7 @@ describe("FeishuConfigSchema defaultAccount", () => {
 
     expect(result.success).toBe(false);
     if (!result.success) {
-      expect(result.error.issues.some((issue) => issue.path.join(".") === "defaultAccount")).toBe(
-        true,
-      );
+      expect(result.error.issues.map((issue) => issue.path.join("."))).toContain("defaultAccount");
     }
   });
 });
diff --git a/extensions/feishu/src/security-audit.test.ts b/extensions/feishu/src/security-audit.test.ts
index edeb0e29aeb..e6109a72cfe 100644
--- a/extensions/feishu/src/security-audit.test.ts
+++ b/extensions/feishu/src/security-audit.test.ts
@@ -47,15 +47,13 @@ describe("Feishu security audit findings", () => {
     },
   ])("$name", ({ cfg, expectedFinding, expectedNoFinding }) => {
     const findings = collectFeishuSecurityAuditFindings({ cfg });
+    const findingKeys = findings.map((finding) => `${finding.checkId}:${finding.severity}`);
+    const checkIds = findings.map((finding) => finding.checkId);
     if (expectedFinding) {
-      expect(
-        findings.some(
-          (finding) => finding.checkId === expectedFinding && finding.severity === "warn",
-        ),
-      ).toBe(true);
+      expect(findingKeys).toContain(`${expectedFinding}:warn`);
     }
     if (expectedNoFinding) {
-      expect(findings.some((finding) => finding.checkId === expectedNoFinding)).toBe(false);
+      expect(checkIds).not.toContain(expectedNoFinding);
     }
   });
 });