From 2e8a2d617d9b014c56394acbc394ac096cd680eb Mon Sep 17 00:00:00 2001 From: Song Zhenlin <120006171+whiteyzy@users.noreply.github.com> Date: Sat, 13 Jun 2026 21:39:51 +0800 Subject: [PATCH] fix(browser): remove dead requireRef navigation import Remove the unused requireRef import and void anchor from Browser navigation command registration while keeping navigate/resize registration covered by regression tests. Fixes #83878. --- .../register.navigation.test.ts | 14 ++++++++++++++ .../register.navigation.ts | 5 +---- 2 files changed, 15 insertions(+), 4 deletions(-) diff --git a/extensions/browser/src/cli/browser-cli-actions-input/register.navigation.test.ts b/extensions/browser/src/cli/browser-cli-actions-input/register.navigation.test.ts index 8fe0e5bcc21..4b38d68011a 100644 --- a/extensions/browser/src/cli/browser-cli-actions-input/register.navigation.test.ts +++ b/extensions/browser/src/cli/browser-cli-actions-input/register.navigation.test.ts @@ -61,4 +61,18 @@ describe("browser navigation commands", () => { expect(capture.runtimeErrors.join("\n")).toContain("Invalid width: maximum is 8192"); expect(mocks.runBrowserResizeWithOutput).not.toHaveBeenCalled(); }); + + it("navigate and resize commands are registered after removing dead import (#83878)", async () => { + const program = createNavigationProgram(); + const browserCmd = program.commands.find((c) => c.name() === "browser"); + expect(browserCmd).toBeDefined(); + + const cmds = browserCmd!.commands.map((c) => c.name()); + expect(cmds).toContain("resize"); + expect(cmds).toContain("navigate"); + + // Verify the shared module still exports requireRef (used by other modules) + const shared = await import("./shared.js"); + expect(typeof shared.requireRef).toBe("function"); + }); }); diff --git a/extensions/browser/src/cli/browser-cli-actions-input/register.navigation.ts b/extensions/browser/src/cli/browser-cli-actions-input/register.navigation.ts index 6bcc9801d67..1af2360107e 100644 --- a/extensions/browser/src/cli/browser-cli-actions-input/register.navigation.ts +++ b/extensions/browser/src/cli/browser-cli-actions-input/register.navigation.ts @@ -12,7 +12,7 @@ import { type BrowserParentOpts, } from "../browser-cli-shared.js"; import { danger, defaultRuntime } from "../core-api.js"; -import { requireRef, resolveBrowserActionContext } from "./shared.js"; +import { resolveBrowserActionContext } from "./shared.js"; /** Registers Browser navigate and resize commands. */ export function registerBrowserNavigationCommands( @@ -94,7 +94,4 @@ export function registerBrowserNavigationCommands( defaultRuntime.exit(1); } }); - - // Keep `requireRef` reachable; shared utilities are intended for other modules too. - void requireRef; }