CLI: add root --help fast path and lazy channel option resolution (#30975)

* CLI argv: add strict root help invocation guard

* Entry: add root help fast-path bootstrap bypass

* CLI context: lazily resolve channel options

* CLI context tests: cover lazy channel option resolution

* CLI argv tests: cover root help invocation detection

* Changelog: note additional startup path optimizations

* Changelog: split startup follow-up into #30975 entry

* CLI channel options: load precomputed startup metadata

* CLI channel options tests: cover precomputed metadata path

* Build: generate CLI startup metadata during build

* Build script: invoke CLI startup metadata generator

* CLI routes: preload plugins for routed health

* CLI routes tests: assert health plugin preload

* CLI: add experimental bundled entry and snapshot helper

* Tools: compare CLI startup entries in benchmark script

* Docs: add startup tuning notes for Pi and VM hosts

* CLI: drop bundled entry runtime toggle

* Build: remove bundled and snapshot scripts

* Tools: remove bundled-entry benchmark shortcut

* Docs: remove bundled startup bench examples

* Docs: remove Pi bundled entry mention

* Docs: remove VM bundled entry mention

* Changelog: remove bundled startup follow-up claims

* Build: remove snapshot helper script

* Build: remove CLI bundle tsdown config

* Doctor: add low-power startup optimization hints

* Doctor: run startup optimization hint checks

* Doctor tests: cover startup optimization host targeting

* Doctor tests: mock startup optimization note export

* CLI argv: require strict root-only help fast path

* CLI argv tests: cover mixed root-help invocations

* CLI channel options: merge metadata with runtime catalog

* CLI channel options tests: assert dynamic catalog merge

* Changelog: align #30975 startup follow-up scope

* Docs tests: remove secondary-entry startup bench note

* Docs Pi: add systemd recovery reference link

* Docs VPS: add systemd recovery reference link
This commit is contained in:
Vincent Koc
2026-03-01 14:23:46 -08:00
committed by GitHub
parent dcd19da425
commit 38da2d076c
19 changed files with 667 additions and 31 deletions

View File

@@ -14,24 +14,48 @@ const { createProgramContext } = await import("./context.js");
describe("createProgramContext", () => {
it("builds program context from version and resolved channel options", () => {
resolveCliChannelOptionsMock.mockReturnValue(["telegram", "whatsapp"]);
expect(createProgramContext()).toEqual({
resolveCliChannelOptionsMock.mockClear().mockReturnValue(["telegram", "whatsapp"]);
const ctx = createProgramContext();
expect(ctx).toEqual({
programVersion: "9.9.9-test",
channelOptions: ["telegram", "whatsapp"],
messageChannelOptions: "telegram|whatsapp",
agentChannelOptions: "last|telegram|whatsapp",
});
expect(resolveCliChannelOptionsMock).toHaveBeenCalledOnce();
});
it("handles empty channel options", () => {
resolveCliChannelOptionsMock.mockReturnValue([]);
expect(createProgramContext()).toEqual({
resolveCliChannelOptionsMock.mockClear().mockReturnValue([]);
const ctx = createProgramContext();
expect(ctx).toEqual({
programVersion: "9.9.9-test",
channelOptions: [],
messageChannelOptions: "",
agentChannelOptions: "last",
});
expect(resolveCliChannelOptionsMock).toHaveBeenCalledOnce();
});
it("does not resolve channel options before access", () => {
resolveCliChannelOptionsMock.mockClear();
createProgramContext();
expect(resolveCliChannelOptionsMock).not.toHaveBeenCalled();
});
it("reuses one channel option resolution across all getters", () => {
resolveCliChannelOptionsMock.mockClear().mockReturnValue(["telegram"]);
const ctx = createProgramContext();
expect(ctx.channelOptions).toEqual(["telegram"]);
expect(ctx.messageChannelOptions).toBe("telegram");
expect(ctx.agentChannelOptions).toBe("last|telegram");
expect(resolveCliChannelOptionsMock).toHaveBeenCalledOnce();
});
it("reads program version without resolving channel options", () => {
resolveCliChannelOptionsMock.mockClear();
const ctx = createProgramContext();
expect(ctx.programVersion).toBe("9.9.9-test");
expect(resolveCliChannelOptionsMock).not.toHaveBeenCalled();
});
});

View File

@@ -9,11 +9,24 @@ export type ProgramContext = {
};
export function createProgramContext(): ProgramContext {
const channelOptions = resolveCliChannelOptions();
let cachedChannelOptions: string[] | undefined;
const getChannelOptions = (): string[] => {
if (cachedChannelOptions === undefined) {
cachedChannelOptions = resolveCliChannelOptions();
}
return cachedChannelOptions;
};
return {
programVersion: VERSION,
channelOptions,
messageChannelOptions: channelOptions.join("|"),
agentChannelOptions: ["last", ...channelOptions].join("|"),
get channelOptions() {
return getChannelOptions();
},
get messageChannelOptions() {
return getChannelOptions().join("|");
},
get agentChannelOptions() {
return ["last", ...getChannelOptions()].join("|");
},
};
}

View File

@@ -18,9 +18,9 @@ describe("program routes", () => {
expect(route?.loadPlugins).toBe(true);
});
it("matches health route without eager plugin loading", () => {
it("matches health route and preloads plugins for channel diagnostics", () => {
const route = expectRoute(["health"]);
expect(route?.loadPlugins).toBeUndefined();
expect(route?.loadPlugins).toBe(true);
});
it("returns false when status timeout flag value is missing", async () => {

View File

@@ -9,6 +9,9 @@ export type RouteSpec = {
const routeHealth: RouteSpec = {
match: (path) => path[0] === "health",
// Health output uses channel plugin metadata for account fallback/log details.
// Keep routed behavior aligned with non-routed command execution.
loadPlugins: true,
run: async (argv) => {
const json = hasFlag(argv, "--json");
const verbose = getVerboseFlag(argv, { includeDebug: true });