From 395fc1100523b1ccd47c362693f467c2d2b479a1 Mon Sep 17 00:00:00 2001 From: Peter Steinberger Date: Sat, 2 May 2026 07:53:11 +0100 Subject: [PATCH] refactor: trim tooling helper exports --- scripts/lib/test-group-report.mjs | 6 +++--- scripts/lib/workspace-bootstrap-smoke.mjs | 2 +- scripts/run-additional-boundary-checks.mjs | 2 +- scripts/test-report-utils.mjs | 6 +----- scripts/windows-cmd-helpers.mjs | 2 +- 5 files changed, 7 insertions(+), 11 deletions(-) diff --git a/scripts/lib/test-group-report.mjs b/scripts/lib/test-group-report.mjs index c7f7bc84097..9428f586e43 100644 --- a/scripts/lib/test-group-report.mjs +++ b/scripts/lib/test-group-report.mjs @@ -8,11 +8,11 @@ export function formatBytesAsMb(valueBytes) { : `${(valueBytes / 1024 / 1024).toFixed(1)}MB`; } -export function formatSignedMs(value, digits = 1) { +function formatSignedMs(value, digits = 1) { return `${value > 0 ? "+" : ""}${formatMs(value, digits)}`; } -export function formatSignedBytesAsMb(valueBytes) { +function formatSignedBytesAsMb(valueBytes) { return valueBytes === null || valueBytes === undefined ? "n/a" : `${valueBytes > 0 ? "+" : ""}${formatBytesAsMb(valueBytes)}`; @@ -46,7 +46,7 @@ export function resolveTestArea(file) { return parts[0] || normalized; } -export function resolveTestFolder(file, depth = 2) { +function resolveTestFolder(file, depth = 2) { const normalized = normalizeTrackedRepoPath(file); const dir = path.posix.dirname(normalized); if (dir === ".") { diff --git a/scripts/lib/workspace-bootstrap-smoke.mjs b/scripts/lib/workspace-bootstrap-smoke.mjs index 762e470c3d9..7bdf82e1cab 100644 --- a/scripts/lib/workspace-bootstrap-smoke.mjs +++ b/scripts/lib/workspace-bootstrap-smoke.mjs @@ -23,7 +23,7 @@ const REQUIRED_BOOTSTRAP_WORKSPACE_FILES = [ "BOOTSTRAP.md", ]; -export const WORKSPACE_BOOTSTRAP_SMOKE_TIMEOUT_MS = 15_000; +const WORKSPACE_BOOTSTRAP_SMOKE_TIMEOUT_MS = 15_000; const SAFE_UNIX_SMOKE_PATH = "/usr/bin:/bin"; export function createWorkspaceBootstrapSmokeEnv(env, homeDir, overrides = {}) { diff --git a/scripts/run-additional-boundary-checks.mjs b/scripts/run-additional-boundary-checks.mjs index 82e964e4090..190799f1181 100644 --- a/scripts/run-additional-boundary-checks.mjs +++ b/scripts/run-additional-boundary-checks.mjs @@ -1,7 +1,7 @@ #!/usr/bin/env node import { spawn } from "node:child_process"; -export const BOUNDARY_CHECKS = [ +const BOUNDARY_CHECKS = [ ["plugin-extension-boundary", "pnpm", ["run", "lint:plugins:no-extension-imports"]], ["lint:tmp:no-random-messaging", "pnpm", ["run", "lint:tmp:no-random-messaging"]], ["lint:tmp:channel-agnostic-boundaries", "pnpm", ["run", "lint:tmp:channel-agnostic-boundaries"]], diff --git a/scripts/test-report-utils.mjs b/scripts/test-report-utils.mjs index e97c4fa38a7..d7a0859a039 100644 --- a/scripts/test-report-utils.mjs +++ b/scripts/test-report-utils.mjs @@ -3,7 +3,7 @@ import fs from "node:fs"; import os from "node:os"; import path from "node:path"; -export const normalizeRepoPath = (value) => value.split(path.sep).join("/"); +const normalizeRepoPath = (value) => value.split(path.sep).join("/"); const repoRoot = path.resolve(process.cwd()); export function normalizeTrackedRepoPath(value) { @@ -29,10 +29,6 @@ export function tryReadJsonFile(filePath, fallback) { } } -export function writeJsonFile(filePath, value) { - fs.writeFileSync(filePath, `${JSON.stringify(value, null, 2)}\n`); -} - export function runVitestJsonReport({ config, reportPath = "", diff --git a/scripts/windows-cmd-helpers.mjs b/scripts/windows-cmd-helpers.mjs index 021c2c61cab..8fc69c868c3 100644 --- a/scripts/windows-cmd-helpers.mjs +++ b/scripts/windows-cmd-helpers.mjs @@ -4,7 +4,7 @@ export function resolvePathEnvKey(env) { return Object.keys(env).find((key) => key.toLowerCase() === "path") ?? "PATH"; } -export function escapeForCmdExe(arg) { +function escapeForCmdExe(arg) { if (WINDOWS_UNSAFE_CMD_CHARS_RE.test(arg)) { throw new Error(`unsafe Windows cmd.exe argument detected: ${JSON.stringify(arg)}`); }