From 3adb3dc6c2518b0f4a47e6cbb55f03390bd500c4 Mon Sep 17 00:00:00 2001
From: Peter Steinberger <steipete@gmail.com>
Date: Sat, 9 May 2026 15:53:32 +0100
Subject: [PATCH] test: tighten media status assertions

---
 .../tools/music-generate-tool.status.test.ts  | 67 ++++++++++++-------
 .../tools/sessions-history-tool.test.ts       |  4 +-
 2 files changed, 43 insertions(+), 28 deletions(-)

diff --git a/src/agents/tools/music-generate-tool.status.test.ts b/src/agents/tools/music-generate-tool.status.test.ts
index 1256b3b5322..35a1aea0ce3 100644
--- a/src/agents/tools/music-generate-tool.status.test.ts
+++ b/src/agents/tools/music-generate-tool.status.test.ts
@@ -52,20 +52,29 @@ describe("createMusicGenerateTool status actions", () => {
     expect(result?.content).toHaveLength(1);
     expect(text).toContain("Music generation task task-active is already running with google.");
     expect(text).toContain("Do not call music_generate again for this request.");
-    expect(result?.details).toMatchObject({
-      action: "status",
-      duplicateGuard: true,
-      active: true,
-      existingTask: true,
-      status: "running",
-      taskKind: MUSIC_GENERATION_TASK_KIND,
-      provider: "google",
-      task: {
-        taskId: "task-active",
-        runId: "tool:music_generate:active",
-      },
-      progressSummary: "Generating music",
-    });
+    const details = result?.details as
+      | {
+          action?: unknown;
+          duplicateGuard?: unknown;
+          active?: unknown;
+          existingTask?: unknown;
+          status?: unknown;
+          taskKind?: unknown;
+          provider?: unknown;
+          task?: { taskId?: unknown; runId?: unknown };
+          progressSummary?: unknown;
+        }
+      | undefined;
+    expect(details?.action).toBe("status");
+    expect(details?.duplicateGuard).toBe(true);
+    expect(details?.active).toBe(true);
+    expect(details?.existingTask).toBe(true);
+    expect(details?.status).toBe("running");
+    expect(details?.taskKind).toBe(MUSIC_GENERATION_TASK_KIND);
+    expect(details?.provider).toBe("google");
+    expect(details?.task?.taskId).toBe("task-active");
+    expect(details?.task?.runId).toBe("tool:music_generate:active");
+    expect(details?.progressSummary).toBe("Generating music");
   });
 
   it("reports active task status when action=status is requested", () => {
@@ -92,17 +101,23 @@ describe("createMusicGenerateTool status actions", () => {
     const text = (result.content?.[0] as { text: string } | undefined)?.text ?? "";
 
     expect(text).toContain("Music generation task task-active is already queued with minimax.");
-    expect(result.details).toMatchObject({
-      action: "status",
-      active: true,
-      existingTask: true,
-      status: "queued",
-      taskKind: MUSIC_GENERATION_TASK_KIND,
-      provider: "minimax",
-      task: {
-        taskId: "task-active",
-      },
-      progressSummary: "Queued music generation",
-    });
+    const details = result.details as {
+      action?: unknown;
+      active?: unknown;
+      existingTask?: unknown;
+      status?: unknown;
+      taskKind?: unknown;
+      provider?: unknown;
+      task?: { taskId?: unknown };
+      progressSummary?: unknown;
+    };
+    expect(details.action).toBe("status");
+    expect(details.active).toBe(true);
+    expect(details.existingTask).toBe(true);
+    expect(details.status).toBe("queued");
+    expect(details.taskKind).toBe(MUSIC_GENERATION_TASK_KIND);
+    expect(details.provider).toBe("minimax");
+    expect(details.task?.taskId).toBe("task-active");
+    expect(details.progressSummary).toBe("Queued music generation");
   });
 });
diff --git a/src/agents/tools/sessions-history-tool.test.ts b/src/agents/tools/sessions-history-tool.test.ts
index 94f7b49b8ae..d3fb8514bb6 100644
--- a/src/agents/tools/sessions-history-tool.test.ts
+++ b/src/agents/tools/sessions-history-tool.test.ts
@@ -66,7 +66,7 @@ describe("sessions_history redaction", () => {
 
     expect(serialized).not.toContain("sk-or-v1-abcdef0123456789");
     expect(serialized).toContain("OPENROUTER_API_KEY=");
-    expect(result.details).toMatchObject({ contentRedacted: true });
+    expect((result.details as { contentRedacted?: unknown }).contentRedacted).toBe(true);
   });
 
   it("applies custom redaction patterns to recalled session text", async () => {
@@ -81,6 +81,6 @@ describe("sessions_history redaction", () => {
 
     expect(serialized).not.toContain("internal-ticket-AbC12345");
     expect(serialized).toContain("intern");
-    expect(result.details).toMatchObject({ contentRedacted: true });
+    expect((result.details as { contentRedacted?: unknown }).contentRedacted).toBe(true);
   });
 });