From 3e68035de1dab142e99bc4c735aa626297dfb3cd Mon Sep 17 00:00:00 2001 From: Vincent Koc Date: Sun, 12 Jul 2026 20:46:43 +0200 Subject: [PATCH] refactor(plugins): trim dead export surface (#105612) --- scripts/deadcode-exports.baseline.mjs | 12 ------------ src/plugins/activation-context.ts | 12 +----------- src/plugins/activation-planner.ts | 2 +- src/plugins/catalog-search.ts | 2 +- src/plugins/inspect-shape.ts | 2 +- src/plugins/plugin-cache-primitives.ts | 2 +- src/plugins/plugin-runtime-artifact-resolution.ts | 2 +- 7 files changed, 6 insertions(+), 28 deletions(-) diff --git a/scripts/deadcode-exports.baseline.mjs b/scripts/deadcode-exports.baseline.mjs index fb97fb2aac58..4df524ee8de8 100644 --- a/scripts/deadcode-exports.baseline.mjs +++ b/scripts/deadcode-exports.baseline.mjs @@ -4196,7 +4196,6 @@ export const KNIP_UNUSED_EXPORT_BASELINE = [ "src/infra/ed25519-signature.ts: base64UrlEncode", "src/infra/event-session-routing.ts: parseDirectAgentSessionTarget", "src/infra/exec-approval-forwarder.ts: buildExecApprovalRequestMessage", - "src/infra/exec-approval-policy-snapshot.ts: compareExecApprovalPolicyRules", "src/infra/exec-approval-policy-snapshot.ts: ExecApprovalPolicyRule", "src/infra/exec-approvals-effective.ts: ExecPolicyHostDefaults", "src/infra/exec-approvals.ts: DurableExecApprovalRequirement", @@ -4461,7 +4460,6 @@ export const KNIP_UNUSED_EXPORT_BASELINE = [ "src/infra/sqlite-wal.ts: configureSqliteWalMaintenance", "src/infra/sqlite-wal.ts: DEFAULT_SQLITE_WAL_AUTOCHECKPOINT_PAGES", "src/infra/sqlite-wal.ts: DEFAULT_SQLITE_WAL_CHECKPOINT_INTERVAL_MS", - "src/infra/sqlite-wal.ts: DEFAULT_SQLITE_WAL_TRUNCATE_INTERVAL_MS", "src/infra/sqlite-wal.ts: enableIncrementalAutoVacuumForFreshDatabase", "src/infra/sqlite-wal.ts: SqliteConnectionPragmaOptions", "src/infra/sqlite-wal.ts: SqliteWalMaintenanceOptions", @@ -4661,8 +4659,6 @@ export const KNIP_UNUSED_EXPORT_BASELINE = [ "src/plugins/activation-context.ts: BundledPluginCompatibleLoadValues", "src/plugins/activation-context.ts: PluginActivationCompatConfig", "src/plugins/activation-context.ts: PluginActivationInputs", - "src/plugins/activation-context.ts: PluginActivationSnapshot", - "src/plugins/activation-planner.ts: PluginActivationPlan", "src/plugins/activation-planner.ts: PluginActivationPlanEntry", "src/plugins/activation-planner.ts: PluginActivationPlannerHintReason", "src/plugins/activation-planner.ts: PluginActivationPlannerManifestReason", @@ -4692,7 +4688,6 @@ export const KNIP_UNUSED_EXPORT_BASELINE = [ "src/plugins/bundled-load-path-aliases.ts: PackagedBundledPluginPath", "src/plugins/bundled-plugin-metadata.ts: BundledPluginMetadata", "src/plugins/bundled-sources.ts: BundledPluginLookup", - "src/plugins/catalog-search.ts: PluginCatalogSearchParams", "src/plugins/clawhub.ts: ClawHubInstallErrorCode", "src/plugins/clawhub.ts: formatClawHubSpecifier", "src/plugins/cli-backend.types.ts: CliBackendToolAvailability", @@ -4861,7 +4856,6 @@ export const KNIP_UNUSED_EXPORT_BASELINE = [ "src/plugins/host-hooks.ts: PluginToolPolicyDecision", "src/plugins/host-tool-param-parsers.ts: HostToolDerivationOptions", "src/plugins/host-tool-param-parsers.ts: HostToolDerivedParams", - "src/plugins/inspect-shape.ts: PluginShapeSummary", "src/plugins/install-channel-specs.ts: ChannelInstallSpecs", "src/plugins/install-policy-context.ts: BeforeInstallHookPayloadParams", "src/plugins/install-security-scan.ts: PackageExecutableScanMetadata", @@ -4983,7 +4977,6 @@ export const KNIP_UNUSED_EXPORT_BASELINE = [ "src/plugins/path-safety.ts: resolveSafeRelativePath", "src/plugins/path-safety.ts: splitSafeRelativePath", "src/plugins/plugin-cache-primitives.ts: ConfigScopedPromiseLoader", - "src/plugins/plugin-cache-primitives.ts: PluginLruCacheResult", "src/plugins/plugin-control-plane-context.ts: PluginControlPlaneContext", "src/plugins/plugin-control-plane-context.ts: PluginDiscoveryContext", "src/plugins/plugin-control-plane-context.ts: resolvePluginControlPlaneContext", @@ -5017,7 +5010,6 @@ export const KNIP_UNUSED_EXPORT_BASELINE = [ "src/plugins/plugin-registry-snapshot.ts: PluginRegistryInspection", "src/plugins/plugin-registry-snapshot.ts: PluginRegistrySnapshotDiagnosticCode", "src/plugins/plugin-registry-snapshot.ts: PluginRegistrySnapshotResult", - "src/plugins/plugin-runtime-artifact-resolution.ts: resolvePreferredBuiltRuntimeArtifact", "src/plugins/plugin-sdk-native-resolver.ts: InstallOpenClawPluginSdkNativeResolverOptions", "src/plugins/plugin-sdk-native-resolver.ts: resetOpenClawPluginSdkNativeResolverForTest", "src/plugins/plugin-version-drift.ts: PluginVersionDriftEntry", @@ -5247,7 +5239,6 @@ export const KNIP_UNUSED_EXPORT_BASELINE = [ "src/process/gateway-work-admission.ts: tryBeginGatewayIndependentRootWorkAdmission", "src/process/linux-oom-score.ts: hardenedEnvForChildOomWrap", "src/process/linux-oom-score.ts: wrapArgvForChildOomScoreRaise", - "src/process/spawn-utils.ts: SpawnWithFallbackResult", "src/process/supervisor/adapters/child.ts: ChildAdapter", "src/process/supervisor/adapters/pty.ts: PtyAdapter", "src/process/supervisor/index.ts: createProcessSupervisor", @@ -5255,10 +5246,7 @@ export const KNIP_UNUSED_EXPORT_BASELINE = [ "src/process/supervisor/index.ts: RunRecord", "src/process/supervisor/index.ts: RunState", "src/process/supervisor/index.ts: SpawnInput", - "src/process/supervisor/index.ts: SpawnMode", "src/process/supervisor/index.ts: TerminationReason", - "src/process/supervisor/registry.ts: RunRegistry", - "src/process/supervisor/types.ts: SpawnMode", "src/proxy-capture/env.ts: OPENCLAW_DEBUG_PROXY_BLOB_DIR", "src/proxy-capture/env.ts: OPENCLAW_DEBUG_PROXY_CERT_DIR", "src/proxy-capture/env.ts: OPENCLAW_DEBUG_PROXY_DB_PATH", diff --git a/src/plugins/activation-context.ts b/src/plugins/activation-context.ts index 0f8b9cf1ef53..9d983273f6a2 100644 --- a/src/plugins/activation-context.ts +++ b/src/plugins/activation-context.ts @@ -33,16 +33,6 @@ export type PluginActivationInputs = { autoEnabledReasons: Record; }; -export type PluginActivationSnapshot = Pick< - PluginActivationInputs, - | "rawConfig" - | "config" - | "normalized" - | "activationSourceConfig" - | "activationSource" - | "autoEnabledReasons" ->; - export type BundledPluginCompatibleActivationInputs = PluginActivationInputs & { compatPluginIds: string[]; }; @@ -191,7 +181,7 @@ function resolvePluginActivationSnapshot(params: { workspaceDir?: string; applyAutoEnable?: boolean; discovery?: PluginDiscoveryResult; -}): PluginActivationSnapshot { +}): PluginActivationInputs { const env = params.env ?? process.env; const rawConfig = params.rawConfig ?? params.resolvedConfig; let resolvedConfig = params.resolvedConfig ?? params.rawConfig; diff --git a/src/plugins/activation-planner.ts b/src/plugins/activation-planner.ts index 4e8b1f6188db..9d26fec8cf46 100644 --- a/src/plugins/activation-planner.ts +++ b/src/plugins/activation-planner.ts @@ -51,7 +51,7 @@ export type PluginActivationPlanEntry = { reasons: readonly PluginActivationPlannerReason[]; }; -export type PluginActivationPlan = { +type PluginActivationPlan = { trigger: PluginActivationPlannerTrigger; pluginIds: readonly string[]; entries: readonly PluginActivationPlanEntry[]; diff --git a/src/plugins/catalog-search.ts b/src/plugins/catalog-search.ts index c7cc840a525a..571ccfe211ac 100644 --- a/src/plugins/catalog-search.ts +++ b/src/plugins/catalog-search.ts @@ -12,7 +12,7 @@ const INSTALLABLE_PLUGIN_FAMILIES: readonly ClawHubPackageFamily[] = [ const DEFAULT_PLUGIN_SEARCH_LIMIT = 20; const MAX_PLUGIN_SEARCH_LIMIT = 100; -export type PluginCatalogSearchParams = { +type PluginCatalogSearchParams = { query: string; limit?: number; }; diff --git a/src/plugins/inspect-shape.ts b/src/plugins/inspect-shape.ts index 8274866b0d9c..85237d98c000 100644 --- a/src/plugins/inspect-shape.ts +++ b/src/plugins/inspect-shape.ts @@ -33,7 +33,7 @@ export type PluginCapabilityEntry = { ids: string[]; }; -export type PluginShapeSummary = { +type PluginShapeSummary = { shape: PluginInspectShape; capabilityMode: "none" | "plain" | "hybrid"; capabilityCount: number; diff --git a/src/plugins/plugin-cache-primitives.ts b/src/plugins/plugin-cache-primitives.ts index f25b98e1de1e..0207da499b6b 100644 --- a/src/plugins/plugin-cache-primitives.ts +++ b/src/plugins/plugin-cache-primitives.ts @@ -2,7 +2,7 @@ import type { OpenClawConfig } from "../config/types.openclaw.js"; /** Result shape for cache lookups that need to distinguish a miss from cached `undefined`. */ -export type PluginLruCacheResult = { hit: true; value: T } | { hit: false }; +type PluginLruCacheResult = { hit: true; value: T } | { hit: false }; /** Small process-local LRU cache used for stable plugin metadata and loader artifacts. */ export class PluginLruCache { diff --git a/src/plugins/plugin-runtime-artifact-resolution.ts b/src/plugins/plugin-runtime-artifact-resolution.ts index 76cc3255f074..31f3370d0418 100644 --- a/src/plugins/plugin-runtime-artifact-resolution.ts +++ b/src/plugins/plugin-runtime-artifact-resolution.ts @@ -97,7 +97,7 @@ function resolvePackageLocalDistRuntimeArtifact(params: { return null; } -export function resolvePreferredBuiltRuntimeArtifact(params: { +function resolvePreferredBuiltRuntimeArtifact(params: { source: string; rootDir: string; origin: PluginOrigin;