From 3ff606e490966f78ae62b2b7fbc8e4287baee2dc Mon Sep 17 00:00:00 2001 From: Vincent Koc Date: Mon, 6 Apr 2026 11:01:53 +0100 Subject: [PATCH] test(logging): reuse suite temp root tracker in env logger tests --- src/logging/logger-env.test.ts | 23 ++++++++++++++++++++--- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/src/logging/logger-env.test.ts b/src/logging/logger-env.test.ts index aae62fbc5ea..cd8c336184b 100644 --- a/src/logging/logger-env.test.ts +++ b/src/logging/logger-env.test.ts @@ -1,22 +1,33 @@ -import os from "node:os"; +import crypto from "node:crypto"; import path from "node:path"; -import { afterEach, beforeEach, describe, expect, it, vi } from "vitest"; +import { afterAll, afterEach, beforeAll, beforeEach, describe, expect, it, vi } from "vitest"; import { getResolvedConsoleSettings, getResolvedLoggerSettings, resetLogger, setLoggerOverride, } from "../logging.js"; +import { createSuiteTempRootTracker } from "../test-helpers/temp-dir.js"; import { loggingState } from "./state.js"; -const testLogPath = path.join(os.tmpdir(), "openclaw-test-env-log-level.log"); const defaultMaxFileBytes = 500 * 1024 * 1024; +const logRootTracker = createSuiteTempRootTracker({ + prefix: "openclaw-test-env-log-level-", +}); describe("OPENCLAW_LOG_LEVEL", () => { let originalEnv: string | undefined; + let logRoot = ""; + let testLogPath = ""; + + beforeAll(async () => { + await logRootTracker.setup(); + logRoot = await logRootTracker.make("case"); + }); beforeEach(() => { originalEnv = process.env.OPENCLAW_LOG_LEVEL; + testLogPath = path.join(logRoot, `${crypto.randomUUID()}.log`); delete process.env.OPENCLAW_LOG_LEVEL; loggingState.invalidEnvLogLevelValue = null; resetLogger(); @@ -35,6 +46,12 @@ describe("OPENCLAW_LOG_LEVEL", () => { vi.restoreAllMocks(); }); + afterAll(async () => { + await logRootTracker.cleanup(); + logRoot = ""; + testLogPath = ""; + }); + it("applies a valid env override to both file and console levels", () => { setLoggerOverride({ level: "error",