From 403e35e6b00966556448fe4e62a117c2ef4331b7 Mon Sep 17 00:00:00 2001
From: Peter Steinberger <steipete@gmail.com>
Date: Fri, 13 Mar 2026 23:39:17 +0000
Subject: [PATCH] test: share cli help version assertions

---
 src/cli/program/help.test.ts | 44 ++++++++++++++++--------------------
 1 file changed, 19 insertions(+), 25 deletions(-)

diff --git a/src/cli/program/help.test.ts b/src/cli/program/help.test.ts
index 6acceb5cc41..07b6a8d8f90 100644
--- a/src/cli/program/help.test.ts
+++ b/src/cli/program/help.test.ts
@@ -90,6 +90,23 @@ describe("configureProgramHelp", () => {
     }
   }
 
+  function expectVersionExit(params: { expectedVersion: string }) {
+    const logSpy = vi.spyOn(console, "log").mockImplementation(() => {});
+    const exitSpy = vi.spyOn(process, "exit").mockImplementation(((code?: number) => {
+      throw new Error(`exit:${code ?? ""}`);
+    }) as typeof process.exit);
+
+    try {
+      const program = makeProgramWithCommands();
+      expect(() => configureProgramHelp(program, testProgramContext)).toThrow("exit:0");
+      expect(logSpy).toHaveBeenCalledWith(params.expectedVersion);
+      expect(exitSpy).toHaveBeenCalledWith(0);
+    } finally {
+      logSpy.mockRestore();
+      exitSpy.mockRestore();
+    }
+  }
+
   it("adds root help hint and marks commands with subcommands", () => {
     process.argv = ["node", "openclaw", "--help"];
     const program = makeProgramWithCommands();
@@ -115,35 +132,12 @@ describe("configureProgramHelp", () => {
 
   it("prints version and exits immediately when version flags are present", () => {
     process.argv = ["node", "openclaw", "--version"];
-    const logSpy = vi.spyOn(console, "log").mockImplementation(() => {});
-    const exitSpy = vi.spyOn(process, "exit").mockImplementation(((code?: number) => {
-      throw new Error(`exit:${code ?? ""}`);
-    }) as typeof process.exit);
-
-    const program = makeProgramWithCommands();
-    expect(() => configureProgramHelp(program, testProgramContext)).toThrow("exit:0");
-    expect(logSpy).toHaveBeenCalledWith("OpenClaw 9.9.9-test (abc1234)");
-    expect(exitSpy).toHaveBeenCalledWith(0);
-
-    logSpy.mockRestore();
-    exitSpy.mockRestore();
+    expectVersionExit({ expectedVersion: "OpenClaw 9.9.9-test (abc1234)" });
   });
 
   it("prints version and exits immediately without commit metadata", () => {
     process.argv = ["node", "openclaw", "--version"];
     resolveCommitHashMock.mockReturnValue(null);
-
-    const logSpy = vi.spyOn(console, "log").mockImplementation(() => {});
-    const exitSpy = vi.spyOn(process, "exit").mockImplementation(((code?: number) => {
-      throw new Error(`exit:${code ?? ""}`);
-    }) as typeof process.exit);
-
-    const program = makeProgramWithCommands();
-    expect(() => configureProgramHelp(program, testProgramContext)).toThrow("exit:0");
-    expect(logSpy).toHaveBeenCalledWith("OpenClaw 9.9.9-test");
-    expect(exitSpy).toHaveBeenCalledWith(0);
-
-    logSpy.mockRestore();
-    exitSpy.mockRestore();
+    expectVersionExit({ expectedVersion: "OpenClaw 9.9.9-test" });
   });
 });