From 40d2e5aa45880507bb4ac8b1fe54560a7e741b3a Mon Sep 17 00:00:00 2001
From: Peter Steinberger <steipete@gmail.com>
Date: Sat, 18 Apr 2026 22:12:33 +0100
Subject: [PATCH] test: trim slow agent waits

---
 .../bash-tools.exec.background-abort.test.ts  | 15 +++----
 src/agents/skills-install-fallback.test.ts    | 41 -------------------
 2 files changed, 8 insertions(+), 48 deletions(-)

diff --git a/src/agents/bash-tools.exec.background-abort.test.ts b/src/agents/bash-tools.exec.background-abort.test.ts
index 95020c8912a..0067e8e952f 100644
--- a/src/agents/bash-tools.exec.background-abort.test.ts
+++ b/src/agents/bash-tools.exec.background-abort.test.ts
@@ -1,12 +1,13 @@
 import { afterEach, beforeAll, beforeEach, expect, test, vi } from "vitest";
 import { killProcessTree } from "../process/kill-tree.js";
 
-const BACKGROUND_HOLD_CMD = 'node -e "setTimeout(() => {}, 5000)"';
-const ABORT_SETTLE_MS = process.platform === "win32" ? 200 : 25;
-const ABORT_WAIT_TIMEOUT_MS = process.platform === "win32" ? 1_500 : 1_200;
-const POLL_INTERVAL_MS = 15;
-const FINISHED_WAIT_TIMEOUT_MS = process.platform === "win32" ? 8_000 : 3_000;
-const BACKGROUND_TIMEOUT_SEC = process.platform === "win32" ? 0.2 : 0.05;
+const BACKGROUND_HOLD_CMD =
+  process.platform === "win32" ? 'node -e "setTimeout(() => {}, 5000)"' : "exec sleep 5";
+const ABORT_SETTLE_MS = process.platform === "win32" ? 200 : 10;
+const ABORT_WAIT_TIMEOUT_MS = process.platform === "win32" ? 1_500 : 400;
+const POLL_INTERVAL_MS = process.platform === "win32" ? 15 : 5;
+const FINISHED_WAIT_TIMEOUT_MS = process.platform === "win32" ? 8_000 : 1_000;
+const BACKGROUND_TIMEOUT_SEC = process.platform === "win32" ? 0.2 : 0.02;
 const TEST_EXEC_DEFAULTS = {
   host: "gateway" as const,
   security: "full" as const,
@@ -162,7 +163,7 @@ test("background exec without explicit timeout ignores default timeout", async (
   const result = await tool.execute("toolcall", { command: BACKGROUND_HOLD_CMD, background: true });
   expect(result.details.status).toBe("running");
   const sessionId = (result.details as { sessionId: string }).sessionId;
-  const waitMs = Math.max(ABORT_SETTLE_MS + 80, BACKGROUND_TIMEOUT_SEC * 1000 + 80);
+  const waitMs = Math.max(ABORT_SETTLE_MS + 30, BACKGROUND_TIMEOUT_SEC * 1000 + 30);
 
   const startedAt = Date.now();
   await expect
diff --git a/src/agents/skills-install-fallback.test.ts b/src/agents/skills-install-fallback.test.ts
index c05d74cb568..63f9218a4c1 100644
--- a/src/agents/skills-install-fallback.test.ts
+++ b/src/agents/skills-install-fallback.test.ts
@@ -2,7 +2,6 @@ import fs from "node:fs/promises";
 import os from "node:os";
 import path from "node:path";
 import { afterAll, beforeAll, beforeEach, describe, expect, it, vi } from "vitest";
-import { loadWorkspaceDotEnvFile } from "../infra/dotenv.js";
 import { captureEnv } from "../test-utils/env.js";
 import {
   hasBinaryMock,
@@ -217,44 +216,4 @@ describe("skills-install fallback edge cases", () => {
       envSnapshot.restore();
     }
   });
-
-  it("blocks workspace dotenv UV_PYTHON from uv install execution", async () => {
-    mockAvailableBinaries(["uv"]);
-    runCommandWithTimeoutMock.mockResolvedValueOnce({
-      code: 0,
-      stdout: "ok",
-      stderr: "",
-      signal: null,
-      killed: false,
-    });
-
-    const workspaceEnvPath = path.join(workspaceDir, ".env");
-    const envSnapshot = captureEnv(["UV_PYTHON"]);
-    try {
-      delete process.env.UV_PYTHON;
-      await fs.writeFile(workspaceEnvPath, "UV_PYTHON=/tmp/attacker-python\n", "utf-8");
-
-      loadWorkspaceDotEnvFile(workspaceEnvPath, { quiet: true });
-      expect(process.env.UV_PYTHON).toBeUndefined();
-
-      const result = await installSkill({
-        workspaceDir,
-        skillName: "py-tool",
-        installId: "deps",
-        timeoutMs: 10_000,
-      });
-
-      expect(result.ok).toBe(true);
-      expect(runCommandWithTimeoutMock).toHaveBeenCalledWith(
-        ["uv", "tool", "install", "example-package"],
-        expect.objectContaining({
-          timeoutMs: 10_000,
-          env: undefined,
-        }),
-      );
-    } finally {
-      envSnapshot.restore();
-      await fs.rm(workspaceEnvPath, { force: true });
-    }
-  });
 });