From 414bf8a1f821b9b689506bf1a9dd73524cd4a184 Mon Sep 17 00:00:00 2001 From: RamuKaka Date: Sat, 4 Apr 2026 10:48:48 -0700 Subject: [PATCH] =?UTF-8?q?fix(msteams):=20address=20review=20=E2=80=94=20?= =?UTF-8?q?fix=20stale=20JSDoc,=20document=20dist=20import?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Update stale JSDoc that still referenced HttpPlugin (line 348) - Add comment explaining why IHttpServerAdapter uses dist subpath (tsgo cannot resolve the re-export chain from the public barrel) Co-Authored-By: Claude Opus 4.6 (1M context) --- extensions/msteams/src/sdk.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/extensions/msteams/src/sdk.ts b/extensions/msteams/src/sdk.ts index a3ea98b3307..7e1aa0217e9 100644 --- a/extensions/msteams/src/sdk.ts +++ b/extensions/msteams/src/sdk.ts @@ -1,3 +1,5 @@ +// IHttpServerAdapter is re-exported via the public barrel (`export * from './http'`) +// but tsgo cannot resolve the chain. Use the dist subpath directly (type-only import). import type { IHttpServerAdapter } from "@microsoft/teams.apps/dist/http/index.js"; import { formatUnknownError } from "./errors.js"; import type { MSTeamsAdapter } from "./messenger.js"; @@ -345,7 +347,7 @@ async function deleteActivityViaRest(params: { * Build a CloudAdapter-compatible adapter using the Teams SDK REST client. * * This replaces the previous CloudAdapter from @microsoft/agents-hosting. - * For incoming requests: the App's HttpPlugin handles JWT validation. + * For incoming requests: the App's HTTP server handles JWT validation. * For proactive sends: uses the Bot Framework REST API via * @microsoft/teams.api Client. */