refactor: simplify e2e fixture helpers

test/scripts/blacksmith-testbox-runner.test.ts

@@ -1,9 +1,11 @@
+import { EventEmitter } from "node:events";
 import fs from "node:fs";
 import os from "node:os";
 import path from "node:path";
 import { describe, expect, it } from "vitest";
 import {
   buildBlacksmithRunArgs,
+  resolveTestboxSyncTimeoutMs,
   runBlacksmithTestboxRunner,
   splitRunnerArgs,
 } from "../../scripts/blacksmith-testbox-runner.mjs";
@@ -27,10 +29,10 @@ describe("blacksmith testbox runner", () => {
     ).toEqual(["testbox", "run", "--id", "tbx_abc123", "OPENCLAW_TESTBOX=1 pnpm check:changed"]);
   });
 
-  it("refuses to run a remote-visible id without a local private key", () => {
+  it("refuses to run a remote-visible id without a local private key", async () => {
     let spawned = false;
     const stderr = { write: (value: string) => value.length };
-    const code = runBlacksmithTestboxRunner({
+    const code = await runBlacksmithTestboxRunner({
       argv: ["--id", "tbx_01kqap50t9fqggzw1akg5dtmmq", "--", "pnpm", "check:changed"],
       env: { OPENCLAW_BLACKSMITH_TESTBOX_STATE_DIR: "/state/testboxes" },
       spawn: () => {
@@ -44,7 +46,7 @@ describe("blacksmith testbox runner", () => {
     expect(spawned).toBe(false);
   });
 
-  it("refuses to run a keyed id that was not claimed by this checkout", () => {
+  it("refuses to run a keyed id that was not claimed by this checkout", async () => {
     const stateDir = fs.mkdtempSync(path.join(os.tmpdir(), "openclaw-testbox-runner-"));
     const testboxDir = path.join(stateDir, "tbx_01kqap50t9fqggzw1akg5dtmmq");
     fs.mkdirSync(testboxDir, { recursive: true });
@@ -52,7 +54,7 @@ describe("blacksmith testbox runner", () => {
 
     let spawned = false;
     let stderrText = "";
-    const code = runBlacksmithTestboxRunner({
+    const code = await runBlacksmithTestboxRunner({
       argv: ["--id", "tbx_01kqap50t9fqggzw1akg5dtmmq", "--", "pnpm", "check:changed"],
       env: { ...process.env, OPENCLAW_BLACKSMITH_TESTBOX_STATE_DIR: stateDir },
       spawn: () => {
@@ -67,7 +69,7 @@ describe("blacksmith testbox runner", () => {
     expect(stderrText).toContain("OpenClaw Testbox claim missing");
   });
 
-  it("claims a keyed id without spawning when no remote command is supplied", () => {
+  it("claims a keyed id without spawning when no remote command is supplied", async () => {
     const stateDir = fs.mkdtempSync(path.join(os.tmpdir(), "openclaw-testbox-runner-"));
     const testboxDir = path.join(stateDir, "tbx_01kqap50t9fqggzw1akg5dtmmq");
     const claimPath = path.join(testboxDir, "openclaw-runner.json");
@@ -76,7 +78,7 @@ describe("blacksmith testbox runner", () => {
 
     let spawned = false;
     let stdoutText = "";
-    const code = runBlacksmithTestboxRunner({
+    const code = await runBlacksmithTestboxRunner({
       argv: ["--claim", "--id", "tbx_01kqap50t9fqggzw1akg5dtmmq"],
       env: { ...process.env, OPENCLAW_BLACKSMITH_TESTBOX_STATE_DIR: stateDir },
       spawn: () => {
@@ -91,4 +93,57 @@ describe("blacksmith testbox runner", () => {
     expect(stdoutText).toContain("OpenClaw Testbox claim written");
     expect(JSON.parse(fs.readFileSync(claimPath, "utf8")).repoRoot).toBe(process.cwd());
   });
+
+  it("defaults the Testbox sync timeout and accepts disable override", () => {
+    expect(resolveTestboxSyncTimeoutMs({})).toBe(300000);
+    expect(resolveTestboxSyncTimeoutMs({ OPENCLAW_TESTBOX_SYNC_TIMEOUT_MS: "0" })).toBe(0);
+    expect(resolveTestboxSyncTimeoutMs({ OPENCLAW_TESTBOX_SYNC_TIMEOUT_MS: "2500" })).toBe(2500);
+  });
+
+  it("terminates a Testbox run that stalls in sync", async () => {
+    const stateDir = fs.mkdtempSync(path.join(os.tmpdir(), "openclaw-testbox-runner-"));
+    const testboxId = "tbx_01kqap50t9fqggzw1akg5dtmmq";
+    const testboxDir = path.join(stateDir, testboxId);
+    fs.mkdirSync(testboxDir, { recursive: true });
+    fs.writeFileSync(path.join(testboxDir, "id_ed25519"), "test-key\n");
+    await runBlacksmithTestboxRunner({
+      argv: ["--claim", "--id", testboxId],
+      env: { ...process.env, OPENCLAW_BLACKSMITH_TESTBOX_STATE_DIR: stateDir },
+      stdout: { write: () => 0 },
+    });
+
+    let killed = false;
+    let stderrText = "";
+    const fakeSpawn = () => {
+      const child = new EventEmitter() as EventEmitter & {
+        stdout: EventEmitter;
+        stderr: EventEmitter;
+        kill: () => void;
+      };
+      child.stdout = new EventEmitter();
+      child.stderr = new EventEmitter();
+      child.kill = () => {
+        killed = true;
+        child.emit("close", 143);
+      };
+      queueMicrotask(() => child.stdout.emit("data", "Syncing... (still in progress)"));
+      return child;
+    };
+
+    const code = await runBlacksmithTestboxRunner({
+      argv: ["--id", testboxId, "--", "pnpm", "check:changed"],
+      env: {
+        ...process.env,
+        OPENCLAW_BLACKSMITH_TESTBOX_STATE_DIR: stateDir,
+        OPENCLAW_TESTBOX_SYNC_TIMEOUT_MS: "1",
+      },
+      spawn: fakeSpawn,
+      stderr: { write: (value: string) => (stderrText += value) },
+      stdout: { write: () => 0 },
+    });
+
+    expect(code).toBe(124);
+    expect(killed).toBe(true);
+    expect(stderrText).toContain("Blacksmith Testbox sync produced no post-sync output");
+  });
 });