vultr/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-04-12 17:51:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(plugins): stabilize package boundary tsc checks

Browse Source
This commit is contained in:
Vincent Koc
2026-04-07 10:15:03 +01:00
parent 34c78d3ba4
commit 4329d94de3
4 changed files with 178 additions and 65 deletions
Download Patch File Download Diff File Expand all files Collapse all files

70
test/extension-package-tsc-boundary.test.ts
View File

@@ -1,29 +1,12 @@
import { spawnSync } from "node:child_process";
import { rmSync, writeFileSync } from "node:fs";
import { createRequire } from "node:module";
import { resolve } from "node:path";
import { describe, expect, it } from "vitest";
import {
collectOptInExtensionPackageBoundaries,
readExtensionPackageBoundaryTsconfig,
} from "../scripts/lib/extension-package-boundary.ts";
const REPO_ROOT = resolve(import.meta.dirname, "..");
const PREPARE_BOUNDARY_ARTIFACTS_BIN = resolve(
const CHECK_EXTENSION_PACKAGE_BOUNDARY_BIN = resolve(
REPO_ROOT,
"scripts/prepare-extension-package-boundary-artifacts.mjs",
"scripts/check-extension-package-tsc-boundary.mjs",
);
const require = createRequire(import.meta.url);
const TSC_BIN = require.resolve("typescript/bin/tsc");
const OPT_IN_EXTENSION_IDS = collectOptInExtensionPackageBoundaries(REPO_ROOT);
const CANARY_EXTENSION_IDS = [
...new Map(
OPT_IN_EXTENSION_IDS.map((extensionId) => [
JSON.stringify(readExtensionPackageBoundaryTsconfig(extensionId, REPO_ROOT)),
extensionId,
]),
).values(),
];
function runNode(args: string[], timeout: number) {
return spawnSync(process.execPath, args, {
@@ -36,53 +19,12 @@ function runNode(args: string[], timeout: number) {
describe("opt-in extension package TypeScript boundaries", () => {
it("typechecks each opt-in extension cleanly through @openclaw/plugin-sdk", () => {
const prepareResult = runNode([PREPARE_BOUNDARY_ARTIFACTS_BIN], 420_000);
expect(prepareResult.status, `${prepareResult.stdout}\n${prepareResult.stderr}`).toBe(0);
for (const extensionId of OPT_IN_EXTENSION_IDS) {
const result = runNode(
[TSC_BIN, "-p", resolve(REPO_ROOT, "extensions", extensionId, "tsconfig.json"), "--noEmit"],
120_000,
);
expect(result.status, `${extensionId}\n${result.stdout}\n${result.stderr}`).toBe(0);
}
const result = runNode([CHECK_EXTENSION_PACKAGE_BOUNDARY_BIN, "--mode=compile"], 420_000);
expect(result.status, `${result.stdout}\n${result.stderr}`).toBe(0);
}, 300_000);
it("fails when opt-in extensions import src/cli through a relative path", () => {
for (const extensionId of CANARY_EXTENSION_IDS) {
const extensionRoot = resolve(REPO_ROOT, "extensions", extensionId);
const canaryPath = resolve(extensionRoot, "__rootdir_boundary_canary__.ts");
const tsconfigPath = resolve(extensionRoot, "tsconfig.rootdir-canary.json");
try {
writeFileSync(
canaryPath,
'import * as foo from "../../src/cli/acp-cli.ts";\nvoid foo;\nexport {};\n',
"utf8",
);
writeFileSync(
tsconfigPath,
JSON.stringify(
{
extends: "./tsconfig.json",
include: ["./__rootdir_boundary_canary__.ts"],
exclude: [],
},
null,
2,
),
"utf8",
);
const result = runNode([TSC_BIN, "-p", tsconfigPath, "--noEmit"], 120_000);
const output = `${result.stdout}\n${result.stderr}`;
expect(result.status).not.toBe(0);
expect(output).toContain("TS6059");
expect(output).toContain("src/cli/acp-cli.ts");
} finally {
rmSync(canaryPath, { force: true });
rmSync(tsconfigPath, { force: true });
}
}
const result = runNode([CHECK_EXTENSION_PACKAGE_BOUNDARY_BIN, "--mode=canary"], 180_000);
expect(result.status, `${result.stdout}\n${result.stderr}`).toBe(0);
});
});