diff --git a/extensions/feishu/src/accounts.test.ts b/extensions/feishu/src/accounts.test.ts index e8d2e8577b2..5647ac533a3 100644 --- a/extensions/feishu/src/accounts.test.ts +++ b/extensions/feishu/src/accounts.test.ts @@ -436,8 +436,8 @@ describe("resolveFeishuAccount", () => { expect((caught as Error).message).toMatch(/channels\.feishu\.appSecret: unresolved SecretRef/i); }); - it("does not throw when account name is non-string", () => { - expect(() => + it("ignores non-string account names", () => { + expect( resolveFeishuAccount({ cfg: { channels: { @@ -454,6 +454,11 @@ describe("resolveFeishuAccount", () => { } as never, accountId: "main", }), - ).not.toThrow(); + ).toMatchObject({ + accountId: "main", + appId: "cli_123", + appSecret: "secret_456", + name: undefined, + }); }); }); diff --git a/extensions/firecrawl/src/firecrawl-tools.test.ts b/extensions/firecrawl/src/firecrawl-tools.test.ts index d6f84b6c28f..a494e699614 100644 --- a/extensions/firecrawl/src/firecrawl-tools.test.ts +++ b/extensions/firecrawl/src/firecrawl-tools.test.ts @@ -215,9 +215,9 @@ describe("firecrawl tools", () => { }); it("blocks private and non-http scrape targets before Firecrawl requests", () => { - expect(() => + expect( firecrawlClientTesting.assertFirecrawlScrapeTargetAllowed("https://example.com/page"), - ).not.toThrow(); + ).toBeUndefined(); for (const blockedUrl of [ "http://localhost/admin", diff --git a/extensions/google/index.test.ts b/extensions/google/index.test.ts index 4c09c7ddff1..7ba11a69d83 100644 --- a/extensions/google/index.test.ts +++ b/extensions/google/index.test.ts @@ -251,8 +251,8 @@ describe("google provider plugin hooks", () => { if (!bridge) { throw new Error("expected Google realtime bridge"); } - expect(() => bridge.sendAudio(Buffer.alloc(160))).not.toThrow(); - expect(() => bridge.setMediaTimestamp(20)).not.toThrow(); - expect(() => bridge.sendUserMessage?.("hello")).not.toThrow(); + expect(bridge.sendAudio(Buffer.alloc(160))).toBeUndefined(); + expect(bridge.setMediaTimestamp(20)).toBeUndefined(); + expect(bridge.sendUserMessage?.("hello")).toBeUndefined(); }); }); diff --git a/extensions/matrix/src/matrix/client/config.test.ts b/extensions/matrix/src/matrix/client/config.test.ts index c2cc11e1972..ecc6c1ed81b 100644 --- a/extensions/matrix/src/matrix/client/config.test.ts +++ b/extensions/matrix/src/matrix/client/config.test.ts @@ -228,7 +228,7 @@ describe("Matrix auth/config live surfaces", () => { ).toThrow(/not allowlisted in secrets\.providers\.matrix-env\.allowlist/i); }); - it("does not throw when accessToken uses a non-env SecretRef", () => { + it("leaves non-env SecretRef access tokens unresolved", () => { const cfg = { channels: { matrix: { diff --git a/src/commands/models/list.auth-overview.test.ts b/src/commands/models/list.auth-overview.test.ts index 922c76fce90..cb3b45af317 100644 --- a/src/commands/models/list.auth-overview.test.ts +++ b/src/commands/models/list.auth-overview.test.ts @@ -96,7 +96,7 @@ describe("resolveProviderAuthOverview", () => { persistedStores.clear(); }); - it("does not throw when token profile only has tokenRef", () => { + it("labels token profiles that only have tokenRef", () => { const overview = resolveProviderAuthOverview({ provider: "github-copilot", cfg: {},