From 463d39d6868335ddd6b7c0737322e655830751ee Mon Sep 17 00:00:00 2001 From: Gustavo Madeira Santana Date: Wed, 1 Apr 2026 12:21:43 -0400 Subject: [PATCH] test: align Slack approval fallback coverage --- .../slack/src/monitor/exec-approvals.test.ts | 35 ------------------- 1 file changed, 35 deletions(-) diff --git a/extensions/slack/src/monitor/exec-approvals.test.ts b/extensions/slack/src/monitor/exec-approvals.test.ts index dc0c76e3beb..2040d136fc2 100644 --- a/extensions/slack/src/monitor/exec-approvals.test.ts +++ b/extensions/slack/src/monitor/exec-approvals.test.ts @@ -103,41 +103,6 @@ describe("SlackExecApprovalHandler", () => { ); }); - it("accepts approvers inferred from allowFrom without requiring explicit execApprovals.approvers", async () => { - const app = buildApp(); - const cfg = { - channels: { - slack: { - botToken: "xoxb-test", - appToken: "xapp-test", - allowFrom: ["U123APPROVER"], - execApprovals: { - enabled: true, - target: "dm", - }, - }, - }, - } as OpenClawConfig; - const handler = new SlackExecApprovalHandler({ - app, - accountId: "default", - config: cfg.channels!.slack!.execApprovals!, - cfg, - }); - - await handler.handleApprovalRequested(buildRequest()); - - expect(sendMessageSlackMock).toHaveBeenCalledTimes(2); - expect(sendMessageSlackMock).toHaveBeenNthCalledWith( - 2, - "user:U123APPROVER", - expect.stringContaining("Exec approval required"), - expect.objectContaining({ - accountId: "default", - }), - ); - }); - it("does not post a redundant DM redirect notice when the origin is already the approver DM", async () => { const app = buildApp(); const handler = new SlackExecApprovalHandler({