mirror of
https://github.com/openclaw/openclaw.git
synced 2026-05-05 05:50:22 +00:00
!refactor(browser): remove Chrome extension path and add MCP doctor migration (#47893)
* Browser: replace extension path with Chrome MCP * Browser: clarify relay stub and doctor checks * Docs: mark browser MCP migration as breaking * Browser: reject unsupported profile drivers * Browser: accept clawd alias on profile create * Doctor: narrow legacy browser driver migration
This commit is contained in:
@@ -1,13 +1,7 @@
|
||||
import { beforeEach, describe, expect, it, vi } from "vitest";
|
||||
|
||||
const { resolveProfileMock, ensureChromeExtensionRelayServerMock } = vi.hoisted(() => ({
|
||||
resolveProfileMock: vi.fn(),
|
||||
ensureChromeExtensionRelayServerMock: vi.fn(),
|
||||
}));
|
||||
|
||||
const { stopOpenClawChromeMock, stopChromeExtensionRelayServerMock } = vi.hoisted(() => ({
|
||||
const { stopOpenClawChromeMock } = vi.hoisted(() => ({
|
||||
stopOpenClawChromeMock: vi.fn(async () => {}),
|
||||
stopChromeExtensionRelayServerMock: vi.fn(async () => true),
|
||||
}));
|
||||
|
||||
const { createBrowserRouteContextMock, listKnownProfileNamesMock } = vi.hoisted(() => ({
|
||||
@@ -19,15 +13,6 @@ vi.mock("./chrome.js", () => ({
|
||||
stopOpenClawChrome: stopOpenClawChromeMock,
|
||||
}));
|
||||
|
||||
vi.mock("./config.js", () => ({
|
||||
resolveProfile: resolveProfileMock,
|
||||
}));
|
||||
|
||||
vi.mock("./extension-relay.js", () => ({
|
||||
ensureChromeExtensionRelayServer: ensureChromeExtensionRelayServerMock,
|
||||
stopChromeExtensionRelayServer: stopChromeExtensionRelayServerMock,
|
||||
}));
|
||||
|
||||
vi.mock("./server-context.js", () => ({
|
||||
createBrowserRouteContext: createBrowserRouteContextMock,
|
||||
listKnownProfileNames: listKnownProfileNamesMock,
|
||||
@@ -36,49 +21,13 @@ vi.mock("./server-context.js", () => ({
|
||||
import { ensureExtensionRelayForProfiles, stopKnownBrowserProfiles } from "./server-lifecycle.js";
|
||||
|
||||
describe("ensureExtensionRelayForProfiles", () => {
|
||||
beforeEach(() => {
|
||||
resolveProfileMock.mockClear();
|
||||
ensureChromeExtensionRelayServerMock.mockClear();
|
||||
});
|
||||
|
||||
it("starts relay only for extension profiles", async () => {
|
||||
resolveProfileMock.mockImplementation((_resolved: unknown, name: string) => {
|
||||
if (name === "chrome-relay") {
|
||||
return { driver: "extension", cdpUrl: "http://127.0.0.1:18888" };
|
||||
}
|
||||
return { driver: "openclaw", cdpUrl: "http://127.0.0.1:18889" };
|
||||
});
|
||||
ensureChromeExtensionRelayServerMock.mockResolvedValue(undefined);
|
||||
|
||||
await ensureExtensionRelayForProfiles({
|
||||
resolved: {
|
||||
profiles: {
|
||||
"chrome-relay": {},
|
||||
openclaw: {},
|
||||
},
|
||||
} as never,
|
||||
onWarn: vi.fn(),
|
||||
});
|
||||
|
||||
expect(ensureChromeExtensionRelayServerMock).toHaveBeenCalledTimes(1);
|
||||
expect(ensureChromeExtensionRelayServerMock).toHaveBeenCalledWith({
|
||||
cdpUrl: "http://127.0.0.1:18888",
|
||||
});
|
||||
});
|
||||
|
||||
it("reports relay startup errors", async () => {
|
||||
resolveProfileMock.mockReturnValue({ driver: "extension", cdpUrl: "http://127.0.0.1:18888" });
|
||||
ensureChromeExtensionRelayServerMock.mockRejectedValue(new Error("boom"));
|
||||
const onWarn = vi.fn();
|
||||
|
||||
await ensureExtensionRelayForProfiles({
|
||||
resolved: { profiles: { "chrome-relay": {} } } as never,
|
||||
onWarn,
|
||||
});
|
||||
|
||||
expect(onWarn).toHaveBeenCalledWith(
|
||||
'Chrome extension relay init failed for profile "chrome-relay": Error: boom',
|
||||
);
|
||||
it("is a no-op after removing the Chrome extension relay path", async () => {
|
||||
await expect(
|
||||
ensureExtensionRelayForProfiles({
|
||||
resolved: { profiles: {} } as never,
|
||||
onWarn: vi.fn(),
|
||||
}),
|
||||
).resolves.toBeUndefined();
|
||||
});
|
||||
});
|
||||
|
||||
@@ -87,14 +36,13 @@ describe("stopKnownBrowserProfiles", () => {
|
||||
createBrowserRouteContextMock.mockClear();
|
||||
listKnownProfileNamesMock.mockClear();
|
||||
stopOpenClawChromeMock.mockClear();
|
||||
stopChromeExtensionRelayServerMock.mockClear();
|
||||
});
|
||||
|
||||
it("stops all known profiles and ignores per-profile failures", async () => {
|
||||
listKnownProfileNamesMock.mockReturnValue(["openclaw", "chrome-relay"]);
|
||||
listKnownProfileNamesMock.mockReturnValue(["openclaw", "user"]);
|
||||
const stopMap: Record<string, ReturnType<typeof vi.fn>> = {
|
||||
openclaw: vi.fn(async () => {}),
|
||||
"chrome-relay": vi.fn(async () => {
|
||||
user: vi.fn(async () => {
|
||||
throw new Error("profile stop failed");
|
||||
}),
|
||||
};
|
||||
@@ -112,12 +60,12 @@ describe("stopKnownBrowserProfiles", () => {
|
||||
});
|
||||
|
||||
expect(stopMap.openclaw).toHaveBeenCalledTimes(1);
|
||||
expect(stopMap["chrome-relay"]).toHaveBeenCalledTimes(1);
|
||||
expect(stopMap.user).toHaveBeenCalledTimes(1);
|
||||
expect(onWarn).not.toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it("stops tracked runtime browsers even when the profile no longer resolves", async () => {
|
||||
listKnownProfileNamesMock.mockReturnValue(["deleted-local", "deleted-extension"]);
|
||||
listKnownProfileNamesMock.mockReturnValue(["deleted-local"]);
|
||||
createBrowserRouteContextMock.mockReturnValue({
|
||||
forProfile: vi.fn(() => {
|
||||
throw new Error("profile not found");
|
||||
@@ -134,18 +82,7 @@ describe("stopKnownBrowserProfiles", () => {
|
||||
},
|
||||
};
|
||||
const launchedBrowser = localRuntime.running;
|
||||
const extensionRuntime = {
|
||||
profile: {
|
||||
name: "deleted-extension",
|
||||
driver: "extension",
|
||||
cdpUrl: "http://127.0.0.1:19999",
|
||||
},
|
||||
running: null,
|
||||
};
|
||||
const profiles = new Map<string, unknown>([
|
||||
["deleted-local", localRuntime],
|
||||
["deleted-extension", extensionRuntime],
|
||||
]);
|
||||
const profiles = new Map<string, unknown>([["deleted-local", localRuntime]]);
|
||||
const state = {
|
||||
resolved: { profiles: {} },
|
||||
profiles,
|
||||
@@ -158,9 +95,6 @@ describe("stopKnownBrowserProfiles", () => {
|
||||
|
||||
expect(stopOpenClawChromeMock).toHaveBeenCalledWith(launchedBrowser);
|
||||
expect(localRuntime.running).toBeNull();
|
||||
expect(stopChromeExtensionRelayServerMock).toHaveBeenCalledWith({
|
||||
cdpUrl: "http://127.0.0.1:19999",
|
||||
});
|
||||
});
|
||||
|
||||
it("warns when profile enumeration fails", async () => {
|
||||
|
||||
Reference in New Issue
Block a user