From 4b0fddc075fadbf5c2993c8124080db221015d9b Mon Sep 17 00:00:00 2001 From: Peter Steinberger Date: Sun, 22 Feb 2026 22:00:38 +0000 Subject: [PATCH] fix(test): prevent env leak causing models.json CI flake --- ...fault-baseurl-token-exchange-fails.test.ts | 4 +-- test/media-understanding.auto.test.ts | 25 ++++++++++++------- 2 files changed, 17 insertions(+), 12 deletions(-) diff --git a/src/agents/models-config.falls-back-default-baseurl-token-exchange-fails.test.ts b/src/agents/models-config.falls-back-default-baseurl-token-exchange-fails.test.ts index dcb42ae8e55..ed4b0a7100c 100644 --- a/src/agents/models-config.falls-back-default-baseurl-token-exchange-fails.test.ts +++ b/src/agents/models-config.falls-back-default-baseurl-token-exchange-fails.test.ts @@ -32,9 +32,7 @@ describe("models-config", () => { }); globalThis.fetch = fetchMock as unknown as typeof fetch; - await ensureOpenClawModelsJson({ models: { providers: {} } }); - - const agentDir = path.join(process.env.HOME ?? "", ".openclaw", "agents", "main", "agent"); + const { agentDir } = await ensureOpenClawModelsJson({ models: { providers: {} } }); expect(await readCopilotBaseUrl(agentDir)).toBe(DEFAULT_COPILOT_API_BASE_URL); }); }); diff --git a/test/media-understanding.auto.test.ts b/test/media-understanding.auto.test.ts index 4aa1e1a6623..99358115dfe 100644 --- a/test/media-understanding.auto.test.ts +++ b/test/media-understanding.auto.test.ts @@ -39,15 +39,22 @@ const envSnapshot = () => ({ }); const restoreEnv = (snapshot: ReturnType) => { - process.env.PATH = snapshot.PATH; - process.env.SHERPA_ONNX_MODEL_DIR = snapshot.SHERPA_ONNX_MODEL_DIR; - process.env.WHISPER_CPP_MODEL = snapshot.WHISPER_CPP_MODEL; - process.env.OPENAI_API_KEY = snapshot.OPENAI_API_KEY; - process.env.GROQ_API_KEY = snapshot.GROQ_API_KEY; - process.env.DEEPGRAM_API_KEY = snapshot.DEEPGRAM_API_KEY; - process.env.GEMINI_API_KEY = snapshot.GEMINI_API_KEY; - process.env.OPENCLAW_AGENT_DIR = snapshot.OPENCLAW_AGENT_DIR; - process.env.PI_CODING_AGENT_DIR = snapshot.PI_CODING_AGENT_DIR; + const restoreEnvVar = (key: string, value: string | undefined) => { + if (value === undefined) { + delete process.env[key]; + } else { + process.env[key] = value; + } + }; + restoreEnvVar("PATH", snapshot.PATH); + restoreEnvVar("SHERPA_ONNX_MODEL_DIR", snapshot.SHERPA_ONNX_MODEL_DIR); + restoreEnvVar("WHISPER_CPP_MODEL", snapshot.WHISPER_CPP_MODEL); + restoreEnvVar("OPENAI_API_KEY", snapshot.OPENAI_API_KEY); + restoreEnvVar("GROQ_API_KEY", snapshot.GROQ_API_KEY); + restoreEnvVar("DEEPGRAM_API_KEY", snapshot.DEEPGRAM_API_KEY); + restoreEnvVar("GEMINI_API_KEY", snapshot.GEMINI_API_KEY); + restoreEnvVar("OPENCLAW_AGENT_DIR", snapshot.OPENCLAW_AGENT_DIR); + restoreEnvVar("PI_CODING_AGENT_DIR", snapshot.PI_CODING_AGENT_DIR); }; const withEnvSnapshot = async (run: () => Promise): Promise => {