From 4b1c8ac4ec8171b0ff7e11b0367cf11304c205e2 Mon Sep 17 00:00:00 2001
From: mjamiv <142179942+mjamiv@users.noreply.github.com>
Date: Tue, 14 Apr 2026 07:59:32 +0000
Subject: [PATCH] fix(dreaming): align defensive deep-dreaming storage fallback
 with new "separate" default

Address review feedback on #66412.

`writeDeepDreamingReport` is called with a defensive
`params.config.storage ?? { mode: "inline", ... }` fallback for cases
where the config object is loosely constructed (tests, migrations).
After flipping the unset default to `"separate"` in
`src/memory-host-sdk/dreaming.ts`, this hardcoded `"inline"` fallback
would silently re-introduce the old behavior for any caller that
exercises the fallback branch.

Update the fallback to `"separate"` so all default code paths agree.
The `MemoryDreamingStorageMode` type continues to accept all three
documented modes; this is purely a default-value alignment.
---
 extensions/memory-core/src/dreaming.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/extensions/memory-core/src/dreaming.ts b/extensions/memory-core/src/dreaming.ts
index 739b7f8cca5..68172ec25e7 100644
--- a/extensions/memory-core/src/dreaming.ts
+++ b/extensions/memory-core/src/dreaming.ts
@@ -615,7 +615,7 @@ export async function runShortTermDreamingPromotionIfTriggered(params: {
         bodyLines: reportLines,
         nowMs: sweepNowMs,
         timezone: params.config.timezone,
-        storage: params.config.storage ?? { mode: "inline", separateReports: false },
+        storage: params.config.storage ?? { mode: "separate", separateReports: false },
       });
       // Generate dream diary narrative from promoted memories.
       if (params.subagent && (candidates.length > 0 || applied.applied > 0)) {