From 4ec277ca005c1f5ef0705b07d08115360ade32d3 Mon Sep 17 00:00:00 2001 From: Peter Steinberger Date: Sat, 9 May 2026 22:53:45 +0100 Subject: [PATCH] test: tighten cron isolated agent assertions --- .../isolated-agent.model-preflight.test.ts | 10 +++----- src/cron/isolated-agent/run.fast-mode.test.ts | 25 +++++++++---------- 2 files changed, 16 insertions(+), 19 deletions(-) diff --git a/src/cron/isolated-agent.model-preflight.test.ts b/src/cron/isolated-agent.model-preflight.test.ts index 5948ae777f0..174d6ddcde9 100644 --- a/src/cron/isolated-agent.model-preflight.test.ts +++ b/src/cron/isolated-agent.model-preflight.test.ts @@ -72,12 +72,10 @@ describe("runCronIsolatedAgentTurn model provider preflight", () => { lane: "cron", }); - expect(result).toMatchObject({ - status: "skipped", - provider: "ollama", - model: "qwen3:32b", - sessionId: "cron-session", - }); + expect(result.status).toBe("skipped"); + expect(result.provider).toBe("ollama"); + expect(result.model).toBe("qwen3:32b"); + expect(result.sessionId).toBe("cron-session"); expect(result.error).toContain("local provider endpoint is not reachable"); expect(runEmbeddedPiAgentMock).not.toHaveBeenCalled(); }); diff --git a/src/cron/isolated-agent/run.fast-mode.test.ts b/src/cron/isolated-agent/run.fast-mode.test.ts index 8782da113ce..12214b1487d 100644 --- a/src/cron/isolated-agent/run.fast-mode.test.ts +++ b/src/cron/isolated-agent/run.fast-mode.test.ts @@ -96,20 +96,19 @@ async function runFastModeCase(params: { expect(result.status).toBe("ok"); expect(runEmbeddedPiAgentMock).toHaveBeenCalledOnce(); - expect(runEmbeddedPiAgentMock.mock.calls[0][0]).toMatchObject({ - provider: "openai", - model: EXPECTED_OPENAI_MODEL, - fastMode: params.expectedFastMode, - cleanupBundleMcpOnRunEnd: params.expectedCleanupBundleMcpOnRunEnd ?? true, - allowGatewaySubagentBinding: true, - }); + const [embeddedRunParams] = runEmbeddedPiAgentMock.mock.calls[0]; + expect(embeddedRunParams.provider).toBe("openai"); + expect(embeddedRunParams.model).toBe(EXPECTED_OPENAI_MODEL); + expect(embeddedRunParams.fastMode).toBe(params.expectedFastMode); + expect(embeddedRunParams.cleanupBundleMcpOnRunEnd).toBe( + params.expectedCleanupBundleMcpOnRunEnd ?? true, + ); + expect(embeddedRunParams.allowGatewaySubagentBinding).toBe(true); if (params.expectedRetiredSessionId) { - expect(retireSessionMcpRuntimeMock).toHaveBeenCalledWith( - expect.objectContaining({ - sessionId: params.expectedRetiredSessionId, - reason: "cron-session-rollover", - }), - ); + expect(retireSessionMcpRuntimeMock).toHaveBeenCalledOnce(); + const [retireParams] = retireSessionMcpRuntimeMock.mock.calls[0]; + expect(retireParams.sessionId).toBe(params.expectedRetiredSessionId); + expect(retireParams.reason).toBe("cron-session-rollover"); return; } expect(retireSessionMcpRuntimeMock).not.toHaveBeenCalled();