From 4fd1b17cf0188f54798794f4e454d98c6f9aef2e Mon Sep 17 00:00:00 2001 From: Peter Steinberger Date: Fri, 1 May 2026 23:12:53 +0100 Subject: [PATCH] refactor: trim hooks local exports --- src/hooks/config.ts | 4 +--- src/hooks/gmail.ts | 2 +- src/hooks/plugin-hooks.ts | 2 +- src/hooks/policy.ts | 8 ++++---- src/hooks/workspace.ts | 2 +- 5 files changed, 8 insertions(+), 10 deletions(-) diff --git a/src/hooks/config.ts b/src/hooks/config.ts index 7d5e182fa09..fa9a36e0226 100644 --- a/src/hooks/config.ts +++ b/src/hooks/config.ts @@ -3,8 +3,6 @@ import { evaluateRuntimeEligibility, hasBinary, isConfigPathTruthyWithDefaults, - resolveConfigPath, - resolveRuntimePlatform, } from "../shared/config-eval.js"; import { resolveHookConfig, resolveHookEnableState } from "./policy.js"; import type { HookEligibilityContext, HookEntry } from "./types.js"; @@ -15,7 +13,7 @@ const DEFAULT_CONFIG_VALUES: Record = { "workspace.dir": true, }; -export { hasBinary, resolveConfigPath, resolveRuntimePlatform }; +export { hasBinary }; export function isConfigPathTruthy(config: OpenClawConfig | undefined, pathStr: string): boolean { return isConfigPathTruthyWithDefaults(config, pathStr, DEFAULT_CONFIG_VALUES); diff --git a/src/hooks/gmail.ts b/src/hooks/gmail.ts index 8198b9e1b45..c72e07017e0 100644 --- a/src/hooks/gmail.ts +++ b/src/hooks/gmail.ts @@ -14,7 +14,7 @@ export const DEFAULT_GMAIL_SERVE_PORT = 8788; export const DEFAULT_GMAIL_SERVE_PATH = "/gmail-pubsub"; export const DEFAULT_GMAIL_MAX_BYTES = 20_000; export const DEFAULT_GMAIL_RENEW_MINUTES = 12 * 60; -export const DEFAULT_HOOKS_PATH = "/hooks"; +const DEFAULT_HOOKS_PATH = "/hooks"; const GMAIL_WATCH_SENSITIVE_FLAGS = new Set(["--token", "--hook-url", "--hook-token"]); export type GmailHookOverrides = { diff --git a/src/hooks/plugin-hooks.ts b/src/hooks/plugin-hooks.ts index 9634940799c..ea1692a3268 100644 --- a/src/hooks/plugin-hooks.ts +++ b/src/hooks/plugin-hooks.ts @@ -13,7 +13,7 @@ import { isPathInsideWithRealpath } from "../security/scan-paths.js"; const log = createSubsystemLogger("hooks"); -export type PluginHookDirEntry = { +type PluginHookDirEntry = { dir: string; pluginId: string; }; diff --git a/src/hooks/policy.ts b/src/hooks/policy.ts index 2fbaa83cbe8..d7343379e26 100644 --- a/src/hooks/policy.ts +++ b/src/hooks/policy.ts @@ -4,12 +4,12 @@ import type { HookEntry, HookSource } from "./types.js"; export type HookEnableStateReason = "disabled in config" | "workspace hook (disabled by default)"; -export type HookEnableState = { +type HookEnableState = { enabled: boolean; reason?: HookEnableStateReason; }; -export type HookSourcePolicy = { +type HookSourcePolicy = { precedence: number; trustedLocalCode: boolean; defaultEnableMode: "default-on" | "explicit-opt-in"; @@ -17,7 +17,7 @@ export type HookSourcePolicy = { canBeOverriddenBy: HookSource[]; }; -export type HookResolutionCollision = { +type HookResolutionCollision = { name: string; kept: HookEntry; ignored: HookEntry; @@ -54,7 +54,7 @@ const HOOK_SOURCE_POLICIES: Record = { }, }; -export function getHookSourcePolicy(source: HookSource): HookSourcePolicy { +function getHookSourcePolicy(source: HookSource): HookSourcePolicy { return HOOK_SOURCE_POLICIES[source]; } diff --git a/src/hooks/workspace.ts b/src/hooks/workspace.ts index c4c1a7c3aa4..7fb9463e8d9 100644 --- a/src/hooks/workspace.ts +++ b/src/hooks/workspace.ts @@ -223,7 +223,7 @@ export function loadHookEntriesFromDir(params: { }); } -export function discoverWorkspaceHookEntries( +function discoverWorkspaceHookEntries( workspaceDir: string, opts?: { config?: OpenClawConfig;