From 506f564fb983e7d7aa6402a86dfa1e7ce322d4ff Mon Sep 17 00:00:00 2001 From: Peter Steinberger Date: Fri, 10 Apr 2026 21:49:54 +0100 Subject: [PATCH] refactor: remove redundant telegram conversions --- extensions/telegram/src/audit.ts | 4 ++-- extensions/telegram/src/command-config.ts | 4 ++-- extensions/telegram/src/security-audit.ts | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/extensions/telegram/src/audit.ts b/extensions/telegram/src/audit.ts index 9bfeb43080a..35aa7bfbf49 100644 --- a/extensions/telegram/src/audit.ts +++ b/extensions/telegram/src/audit.ts @@ -21,7 +21,7 @@ export function collectTelegramUnmentionedGroupIds( }; } const hasWildcardUnmentionedGroups = - Boolean(groups["*"]?.requireMention === false) && groups["*"]?.enabled !== false; + groups["*"]?.requireMention === false && groups["*"]?.enabled !== false; const groupIds: string[] = []; let unresolvedGroups = 0; for (const [key, value] of Object.entries(groups)) { @@ -37,7 +37,7 @@ export function collectTelegramUnmentionedGroupIds( if (value.requireMention !== false) { continue; } - const id = normalizeOptionalString(String(key)) ?? ""; + const id = normalizeOptionalString(key) ?? ""; if (!id) { continue; } diff --git a/extensions/telegram/src/command-config.ts b/extensions/telegram/src/command-config.ts index 7ee06001c8d..902d6a9af49 100644 --- a/extensions/telegram/src/command-config.ts +++ b/extensions/telegram/src/command-config.ts @@ -45,7 +45,7 @@ export function resolveTelegramCustomCommands(params: { for (let index = 0; index < entries.length; index += 1) { const entry = entries[index]; - const normalized = normalizeTelegramCommandName(String(entry?.command ?? "")); + const normalized = normalizeTelegramCommandName(entry?.command ?? ""); if (!normalized) { issues.push({ index, @@ -78,7 +78,7 @@ export function resolveTelegramCustomCommands(params: { }); continue; } - const description = normalizeTelegramCommandDescription(String(entry?.description ?? "")); + const description = normalizeTelegramCommandDescription(entry?.description ?? ""); if (!description) { issues.push({ index, diff --git a/extensions/telegram/src/security-audit.ts b/extensions/telegram/src/security-audit.ts index bdb68ae81d9..4c2e6ab9d69 100644 --- a/extensions/telegram/src/security-audit.ts +++ b/extensions/telegram/src/security-audit.ts @@ -54,7 +54,7 @@ export async function collectTelegramSecurityAuditFindings(params: { () => [], ); const storeHasWildcard = storeAllowFrom.some( - (value) => (normalizeOptionalString(String(value)) ?? "") === "*", + (value) => (normalizeOptionalString(value) ?? "") === "*", ); const invalidTelegramAllowFromEntries = new Set(); collectInvalidTelegramAllowFromEntries({