From 520e704bfdb18d45085b89757d76dfc57e72d235 Mon Sep 17 00:00:00 2001
From: Peter Steinberger <steipete@gmail.com>
Date: Mon, 11 May 2026 03:49:18 +0100
Subject: [PATCH] test: tighten provider usage auth assertions

---
 src/infra/provider-usage.auth.plugin.test.ts | 50 ++++++--------------
 1 file changed, 15 insertions(+), 35 deletions(-)

diff --git a/src/infra/provider-usage.auth.plugin.test.ts b/src/infra/provider-usage.auth.plugin.test.ts
index 97e47626b81..05f4d336578 100644
--- a/src/infra/provider-usage.auth.plugin.test.ts
+++ b/src/infra/provider-usage.auth.plugin.test.ts
@@ -47,6 +47,14 @@ async function withTempHome<T>(fn: (homeDir: string) => Promise<T>): Promise<T>
   }
 }
 
+function providerCalls(mockFn: { mock: { calls: unknown[][] } }): unknown[] {
+  return mockFn.mock.calls.map(([params]) =>
+    params && typeof params === "object" && "provider" in params
+      ? (params as { provider?: unknown }).provider
+      : undefined,
+  );
+}
+
 describe("resolveProviderAuths plugin boundary", () => {
   beforeAll(async () => {
     ({ resolveProviderAuths } = await import("./provider-usage.auth.js"));
@@ -126,11 +134,7 @@ describe("resolveProviderAuths plugin boundary", () => {
       ]);
     });
 
-    expect(resolveProviderUsageAuthWithPluginMock).toHaveBeenCalledWith(
-      expect.objectContaining({
-        provider: "zai",
-      }),
-    );
+    expect(providerCalls(resolveProviderUsageAuthWithPluginMock)).toEqual(["zai"]);
     expect(ensureAuthProfileStoreMock).not.toHaveBeenCalled();
   });
 
@@ -160,11 +164,7 @@ describe("resolveProviderAuths plugin boundary", () => {
     });
 
     expect(resolveProviderUsageAuthWithPluginMock).toHaveBeenCalledTimes(1);
-    expect(resolveProviderUsageAuthWithPluginMock).toHaveBeenCalledWith(
-      expect.objectContaining({
-        provider: "zai",
-      }),
-    );
+    expect(providerCalls(resolveProviderUsageAuthWithPluginMock)).toEqual(["zai"]);
   });
 
   it("keeps auth-profile credential sources provider-specific", async () => {
@@ -205,11 +205,7 @@ describe("resolveProviderAuths plugin boundary", () => {
     });
 
     expect(resolveProviderUsageAuthWithPluginMock).toHaveBeenCalledTimes(1);
-    expect(resolveProviderUsageAuthWithPluginMock).toHaveBeenCalledWith(
-      expect.objectContaining({
-        provider: "anthropic",
-      }),
-    );
+    expect(providerCalls(resolveProviderUsageAuthWithPluginMock)).toEqual(["anthropic"]);
     expect(ensureAuthProfileStoreMock).not.toHaveBeenCalled();
   });
 
@@ -250,16 +246,8 @@ describe("resolveProviderAuths plugin boundary", () => {
       ]);
     });
 
-    expect(resolveAuthProfileOrderMock).toHaveBeenCalledWith(
-      expect.objectContaining({
-        provider: "minimax-portal",
-      }),
-    );
-    expect(resolveProviderUsageAuthWithPluginMock).toHaveBeenCalledWith(
-      expect.objectContaining({
-        provider: "minimax",
-      }),
-    );
+    expect(providerCalls(resolveAuthProfileOrderMock)).toEqual(["minimax", "minimax-portal"]);
+    expect(providerCalls(resolveProviderUsageAuthWithPluginMock)).toEqual(["minimax"]);
     expect(ensureAuthProfileStoreMock).not.toHaveBeenCalled();
   });
 
@@ -286,11 +274,7 @@ describe("resolveProviderAuths plugin boundary", () => {
       ]);
     });
 
-    expect(resolveProviderUsageAuthWithPluginMock).toHaveBeenCalledWith(
-      expect.objectContaining({
-        provider: "minimax",
-      }),
-    );
+    expect(providerCalls(resolveProviderUsageAuthWithPluginMock)).toEqual(["minimax"]);
     expect(ensureAuthProfileStoreMock).not.toHaveBeenCalled();
   });
 
@@ -332,10 +316,6 @@ describe("resolveProviderAuths plugin boundary", () => {
     });
 
     expect(resolveProviderUsageAuthWithPluginMock).toHaveBeenCalledTimes(1);
-    expect(resolveProviderUsageAuthWithPluginMock).toHaveBeenCalledWith(
-      expect.objectContaining({
-        provider: "anthropic",
-      }),
-    );
+    expect(providerCalls(resolveProviderUsageAuthWithPluginMock)).toEqual(["anthropic"]);
   });
 });