vultr/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-05-02 15:10:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(plugins): guard runtime facade activation (#59412)

Browse Source 
* fix(plugins): guard runtime facade activation

* refactor(plugin-sdk): localize facade load policy

* fix(plugin-sdk): narrow facade activation guards

* fix(browser): keep cleanup helpers outside activation guard

* style(browser): apply formatter follow-ups

* chore(changelog): note plugin activation guard regressions

* fix(discord): keep cleanup thread unbinds outside activation guard

* fix(browser): fallback when trash exits non-zero
This commit is contained in:
Vincent Koc
2026-04-02 14:37:12 +09:00
committed by GitHub
parent ed6012eb5b
commit 52a018680d
27 changed files with 509 additions and 57 deletions
Download Patch File Download Diff File Expand all files Collapse all files

43
src/plugin-activation-boundary.test.ts
View File

@@ -34,6 +34,7 @@ describe("plugin activation boundary", () => {
DEFAULT_OPENCLAW_BROWSER_COLOR: typeof import("./plugin-sdk/browser-runtime.js").DEFAULT_OPENCLAW_BROWSER_COLOR;
DEFAULT_OPENCLAW_BROWSER_PROFILE_NAME: typeof import("./plugin-sdk/browser-runtime.js").DEFAULT_OPENCLAW_BROWSER_PROFILE_NAME;
DEFAULT_UPLOAD_DIR: typeof import("./plugin-sdk/browser-runtime.js").DEFAULT_UPLOAD_DIR;
closeTrackedBrowserTabsForSessions: typeof import("./plugin-sdk/browser-runtime.js").closeTrackedBrowserTabsForSessions;
redactCdpUrl: typeof import("./plugin-sdk/browser-runtime.js").redactCdpUrl;
resolveBrowserConfig: typeof import("./plugin-sdk/browser-runtime.js").resolveBrowserConfig;
resolveBrowserControlAuth: typeof import("./plugin-sdk/browser-runtime.js").resolveBrowserControlAuth;
@@ -41,6 +42,11 @@ describe("plugin activation boundary", () => {
}>
| undefined;
let browserAmbientImportsPromise: Promise<void> | undefined;
let discordMaintenancePromise:
| Promise<{
unbindThreadBindingsBySessionKey: typeof import("./plugin-sdk/discord-thread-bindings.js").unbindThreadBindingsBySessionKey;
}>
| undefined;
function importAmbientModules() {
ambientImportsPromise ??= Promise.all([
@@ -77,6 +83,7 @@ describe("plugin activation boundary", () => {
DEFAULT_OPENCLAW_BROWSER_COLOR: module.DEFAULT_OPENCLAW_BROWSER_COLOR,
DEFAULT_OPENCLAW_BROWSER_PROFILE_NAME: module.DEFAULT_OPENCLAW_BROWSER_PROFILE_NAME,
DEFAULT_UPLOAD_DIR: module.DEFAULT_UPLOAD_DIR,
closeTrackedBrowserTabsForSessions: module.closeTrackedBrowserTabsForSessions,
redactCdpUrl: module.redactCdpUrl,
resolveBrowserConfig: module.resolveBrowserConfig,
resolveBrowserControlAuth: module.resolveBrowserControlAuth,
@@ -96,6 +103,15 @@ describe("plugin activation boundary", () => {
return browserAmbientImportsPromise;
}
function importDiscordMaintenance() {
discordMaintenancePromise ??= import("./plugin-sdk/discord-thread-bindings.js").then(
(module) => ({
unbindThreadBindingsBySessionKey: module.unbindThreadBindingsBySessionKey,
}),
);
return discordMaintenancePromise;
}
it("does not load bundled provider plugins on ambient command imports", async () => {
await importAmbientModules();
@@ -143,9 +159,30 @@ describe("plugin activation boundary", () => {
cdpHost: "127.0.0.1",
}),
);
expect(browser.redactCdpUrl("wss://user:secret@example.com/devtools/browser/123")).not.toContain(
"secret",
);
expect(
browser.redactCdpUrl("wss://user:secret@example.com/devtools/browser/123"),
).not.toContain("secret");
expect(loadBundledPluginPublicSurfaceModuleSync).not.toHaveBeenCalled();
});
it("keeps browser cleanup helpers cold when browser is disabled", async () => {
const browser = await importBrowserHelpers();
await expect(browser.closeTrackedBrowserTabsForSessions({ sessionKeys: [] })).resolves.toBe(0);
expect(loadBundledPluginPublicSurfaceModuleSync).not.toHaveBeenCalled();
});
it("keeps discord cleanup helpers cold when discord is disabled", async () => {
const discord = await importDiscordMaintenance();
expect(
discord.unbindThreadBindingsBySessionKey({
targetSessionKey: "agent:main:test",
targetKind: "acp",
reason: "session-reset",
sendFarewell: true,
}),
).toEqual([]);
expect(loadBundledPluginPublicSurfaceModuleSync).not.toHaveBeenCalled();
});