From 52dbc4d6807b98c9364eb53e14d191b80487ab87 Mon Sep 17 00:00:00 2001 From: Vincent Koc Date: Sun, 3 May 2026 17:04:25 -0700 Subject: [PATCH] test(qa): narrow Matrix approval test id --- extensions/qa-matrix/src/runners/contract/scenarios.test.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/extensions/qa-matrix/src/runners/contract/scenarios.test.ts b/extensions/qa-matrix/src/runners/contract/scenarios.test.ts index e03fe69991d..d7f931b4744 100644 --- a/extensions/qa-matrix/src/runners/contract/scenarios.test.ts +++ b/extensions/qa-matrix/src/runners/contract/scenarios.test.ts @@ -379,7 +379,10 @@ describe("matrix live qa scenarios", () => { ); const payload = typeof params === "object" && params !== null ? (params as { id?: unknown }) : undefined; - approvalId = String(payload?.id ?? "approval-missing"); + if (typeof payload?.id !== "string") { + throw new Error("approval request missing id"); + } + approvalId = payload.id; return { id: approvalId, status: "accepted" }; } if (method === "exec.approval.waitDecision") {