vultr/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-05-05 11:10:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(reminder): do not suppress note when sessionKey is unavailable

Browse Source 
Address Greptile review: when sessionKey is undefined the fallback
matched any enabled cron job, which could silently suppress the guard
note due to jobs from unrelated sessions.  Return false instead so the
note always appears when session scoping is not possible.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
scoootscooob
2026-03-02 15:03:40 -08:00
committed by Peter Steinberger
parent abb0252a1a
commit 5868344ade
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/auto-reply/reply/agent-runner.ts
View File

@@ -92,8 +92,10 @@ async function hasSessionRelatedCronJobs(params: {
if (params.sessionKey) {
return store.jobs.some((job) => job.enabled && job.sessionKey === params.sessionKey);
}
// Fallback: any enabled cron job counts.
return store.jobs.some((job) => job.enabled);
// No session key available — cannot scope the check, so do not suppress
// the note. Broadening to all enabled jobs could silently swallow the
// guard note due to unrelated sessions.
return false;
} catch {
// If we cannot read the cron store, do not suppress the note.
return false;