From 5cfcb70962d1908c16b5a994b1fa454ebf35ef0b Mon Sep 17 00:00:00 2001 From: Peter Steinberger Date: Sat, 9 May 2026 11:04:54 +0100 Subject: [PATCH] docs: tighten PR review skill guidance --- .agents/skills/openclaw-pr-maintainer/SKILL.md | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.agents/skills/openclaw-pr-maintainer/SKILL.md b/.agents/skills/openclaw-pr-maintainer/SKILL.md index 20fe0df8d0a..e2fae35aefe 100644 --- a/.agents/skills/openclaw-pr-maintainer/SKILL.md +++ b/.agents/skills/openclaw-pr-maintainer/SKILL.md @@ -108,8 +108,8 @@ Issue triage is review/prove/patch-local by default: 1. Review the issue body, comments, related threads, current code, and adjacent tests. 2. Fix only issues that are easy, high-confidence, and narrowly owned by the implicated path. 3. Add focused regression proof when practical. -4. Stop with the dirty diff, touched files, and test/gate output for Peter's manual review. -5. After Peter approves shipping, make one commit per accepted fix, with its own changelog entry when user-facing. +4. Stop with the dirty diff, touched files, and test/gate output for maintainer review. +5. After maintainer approval to ship, make one commit per accepted fix, with its own changelog entry when user-facing. 6. Pull/rebase, push, then comment and close only the issues that were fixed or explicitly triaged closed. Do not batch unrelated issue fixes into one commit. Do not publish, comment, close, or label during the review/prove phase. @@ -209,6 +209,9 @@ gh search issues --repo openclaw/openclaw --match title,body --limit 50 \ ## Follow PR review and landing hygiene +- Never mention merge conflicts that are relatively easy to resolve, such as + `CHANGELOG.md` entries, in review-only output. These are landing mechanics, + not correctness findings. - If bot review conversations exist on your PR, address them and resolve them yourself once fixed. - Leave a review conversation unresolved only when reviewer or maintainer judgment is still needed. - When landing or merging any PR, follow the global `/landpr` process.