From 5dd3c37fce11ac62c8a8426101ec27ecc946748d Mon Sep 17 00:00:00 2001 From: Ayaan Zaidi Date: Fri, 24 Apr 2026 11:28:54 +0530 Subject: [PATCH] test(release): address npm telegram e2e review --- .github/workflows/npm-telegram-beta-e2e.yml | 4 ++-- test/scripts/npm-telegram-live.test.ts | 5 ++++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/.github/workflows/npm-telegram-beta-e2e.yml b/.github/workflows/npm-telegram-beta-e2e.yml index 6b459598fee..ee4eaddbc11 100644 --- a/.github/workflows/npm-telegram-beta-e2e.yml +++ b/.github/workflows/npm-telegram-beta-e2e.yml @@ -52,7 +52,7 @@ jobs: uses: actions/github-script@v8 with: script: | - const allowed = new Set(["admin", "maintain", "write"]); + const allowed = new Set(["admin", "write"]); const { owner, repo } = context.repo; const { data } = await github.rest.repos.getCollaboratorPermissionLevel({ owner, @@ -63,7 +63,7 @@ jobs: core.info(`Actor ${context.actor} permission: ${permission}`); if (!allowed.has(permission)) { core.setFailed( - `Workflow requires write/maintain/admin access. Actor "${context.actor}" has "${permission}".`, + `Workflow requires write/admin access. Actor "${context.actor}" has "${permission}".`, ); } diff --git a/test/scripts/npm-telegram-live.test.ts b/test/scripts/npm-telegram-live.test.ts index 2ad08facb85..71c5ce40cb2 100644 --- a/test/scripts/npm-telegram-live.test.ts +++ b/test/scripts/npm-telegram-live.test.ts @@ -1,8 +1,11 @@ import { readFileSync } from "node:fs"; +import path from "node:path"; +import { fileURLToPath } from "node:url"; import { describe, expect, it } from "vitest"; import { __testing } from "../../scripts/e2e/npm-telegram-live-runner.ts"; -const DOCKER_SCRIPT_PATH = "scripts/e2e/npm-telegram-live-docker.sh"; +const TEST_DIR = path.dirname(fileURLToPath(import.meta.url)); +const DOCKER_SCRIPT_PATH = path.resolve(TEST_DIR, "../../scripts/e2e/npm-telegram-live-docker.sh"); describe("npm Telegram live Docker E2E", () => { it("supports npm-specific Convex credential aliases", () => {