From 5e055e8887e9762dfade1775fde4bb9d5451a2f6 Mon Sep 17 00:00:00 2001 From: Peter Steinberger Date: Sat, 9 May 2026 02:38:50 +0100 Subject: [PATCH] test: dedupe signal download absence assertions --- extensions/signal/src/install-signal-cli.test.ts | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/extensions/signal/src/install-signal-cli.test.ts b/extensions/signal/src/install-signal-cli.test.ts index 4a7afeada54..7df368f2adf 100644 --- a/extensions/signal/src/install-signal-cli.test.ts +++ b/extensions/signal/src/install-signal-cli.test.ts @@ -82,6 +82,10 @@ function requireAsset(asset: ReleaseAsset | undefined, label: string): ReleaseAs return asset; } +async function expectPathMissing(targetPath: string): Promise { + await expect(fs.access(targetPath)).rejects.toMatchObject({ code: "ENOENT" }); +} + describe("looksLikeArchive", () => { it("recognises .tar.gz", () => { expect(looksLikeArchive("foo.tar.gz")).toBe(true); @@ -204,7 +208,7 @@ describe("downloadToFile", () => { downloadToFile("https://example.com/signal-cli.tgz", filePath, 5, 8), ).rejects.toThrow("declared 12"); - await expect(fs.access(filePath)).rejects.toThrow(); + await expectPathMissing(filePath); }); expect(fetchResult.release).toHaveBeenCalledTimes(1); @@ -226,7 +230,7 @@ describe("downloadToFile", () => { downloadToFile("https://example.com/signal-cli.tgz", filePath, 5, 8), ).rejects.toThrow("8-byte download cap"); - await expect(fs.access(filePath)).rejects.toThrow(); + await expectPathMissing(filePath); }); expect(fetchResult.release).toHaveBeenCalledTimes(1);