From 5e1a2ea01995efaf4c90dbc395209f7d49d475e6 Mon Sep 17 00:00:00 2001 From: riftzen-bit Date: Mon, 2 Mar 2026 17:47:51 -0800 Subject: [PATCH] chore: remove unreachable "LINUX" from resolvePlatform return type Address review feedback: since resolvePlatform() no longer returns "LINUX", remove it from the union type to prevent future confusion. --- extensions/google-gemini-cli-auth/oauth.test.ts | 2 +- extensions/google-gemini-cli-auth/oauth.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/extensions/google-gemini-cli-auth/oauth.test.ts b/extensions/google-gemini-cli-auth/oauth.test.ts index cec301a13e7..86b1fe7c712 100644 --- a/extensions/google-gemini-cli-auth/oauth.test.ts +++ b/extensions/google-gemini-cli-auth/oauth.test.ts @@ -239,7 +239,7 @@ describe("loginGeminiCliOAuth", () => { "GOOGLE_CLOUD_PROJECT_ID", ] as const; - function getExpectedPlatform(): "WINDOWS" | "MACOS" | "LINUX" | "PLATFORM_UNSPECIFIED" { + function getExpectedPlatform(): "WINDOWS" | "MACOS" | "PLATFORM_UNSPECIFIED" { if (process.platform === "win32") { return "WINDOWS"; } diff --git a/extensions/google-gemini-cli-auth/oauth.ts b/extensions/google-gemini-cli-auth/oauth.ts index 4f8f2938e47..1b0d2232833 100644 --- a/extensions/google-gemini-cli-auth/oauth.ts +++ b/extensions/google-gemini-cli-auth/oauth.ts @@ -224,7 +224,7 @@ function generatePkce(): { verifier: string; challenge: string } { return { verifier, challenge }; } -function resolvePlatform(): "WINDOWS" | "MACOS" | "LINUX" | "PLATFORM_UNSPECIFIED" { +function resolvePlatform(): "WINDOWS" | "MACOS" | "PLATFORM_UNSPECIFIED" { if (process.platform === "win32") { return "WINDOWS"; }