From 5f089b6c2c835e7261bd0ea66b7c24238f7c075e Mon Sep 17 00:00:00 2001
From: Peter Steinberger <steipete@gmail.com>
Date: Sat, 11 Apr 2026 00:03:57 +0100
Subject: [PATCH] refactor: simplify discord preflight conversions

---
 .../discord/src/monitor/message-handler.preflight.ts     | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/extensions/discord/src/monitor/message-handler.preflight.ts b/extensions/discord/src/monitor/message-handler.preflight.ts
index 9baf71cd575..d2d0d2f6307 100644
--- a/extensions/discord/src/monitor/message-handler.preflight.ts
+++ b/extensions/discord/src/monitor/message-handler.preflight.ts
@@ -606,7 +606,7 @@ export async function preflightDiscordMessage(
   // Use the active runtime snapshot for bindings lookup; routing inputs are
   // still payload-derived, but this path should not reparse config from disk.
   const memberRoleIds = Array.isArray(params.data.rawMember?.roles)
-    ? params.data.rawMember.roles.map((roleId: string) => String(roleId))
+    ? params.data.rawMember.roles
     : [];
   const freshCfg = loadConfig();
   const conversationRuntime = await loadConversationRuntime();
@@ -697,10 +697,9 @@ export async function preflightDiscordMessage(
       (message.mentionedRoles?.length ?? 0) > 0 ||
       (message.mentionedEveryone && (!author.bot || sender.isPluralKit))),
   );
-  const hasUserOrRoleMention = Boolean(
+  const hasUserOrRoleMention =
     !isDirectMessage &&
-    ((message.mentionedUsers?.length ?? 0) > 0 || (message.mentionedRoles?.length ?? 0) > 0),
-  );
+    ((message.mentionedUsers?.length ?? 0) > 0 || (message.mentionedRoles?.length ?? 0) > 0);
 
   if (
     isGuildMessage &&
@@ -963,7 +962,7 @@ export async function preflightDiscordMessage(
     },
     policy: {
       isGroup: isGuildMessage,
-      requireMention: Boolean(shouldRequireMention),
+      requireMention: shouldRequireMention,
       allowTextCommands,
       hasControlCommand: hasControlCommandInMessage,
       commandAuthorized,