From 5fa11582ae402ed4eba43458ede1eeb3039c5059 Mon Sep 17 00:00:00 2001
From: Peter Steinberger <steipete@gmail.com>
Date: Mon, 20 Apr 2026 21:24:19 +0100
Subject: [PATCH] test: share feishu reaction fixtures

---
 .../feishu/src/comment-reaction.test.ts       | 68 ++++++-------------
 1 file changed, 22 insertions(+), 46 deletions(-)

diff --git a/extensions/feishu/src/comment-reaction.test.ts b/extensions/feishu/src/comment-reaction.test.ts
index e00f2624791..3a3cd9f9ef3 100644
--- a/extensions/feishu/src/comment-reaction.test.ts
+++ b/extensions/feishu/src/comment-reaction.test.ts
@@ -37,16 +37,30 @@ describe("createCommentTypingReactionLifecycle", () => {
     });
   });
 
-  it("adds and removes a comment typing reaction using reply_id", async () => {
-    const lifecycle = createCommentTypingReactionLifecycle({
+  function createTypingReactionLifecycle(...args: [replyId?: string]) {
+    return createCommentTypingReactionLifecycle({
       cfg: {} as ClawdbotConfig,
       fileToken: "doc_token_1",
       fileType: "docx",
-      replyId: "reply_1",
+      replyId: args.length === 0 ? "reply_1" : args[0],
       runtime: {
         log: vi.fn(),
       } as never,
     });
+  }
+
+  const cleanupAmbientReply = () =>
+    cleanupAmbientCommentTypingReaction({
+      client: { request } as never,
+      deliveryContext: {
+        channel: "feishu",
+        to: "comment:docx:doc_token_1:comment_1",
+        threadId: "reply_1",
+      },
+    });
+
+  it("adds and removes a comment typing reaction using reply_id", async () => {
+    const lifecycle = createTypingReactionLifecycle();
 
     await lifecycle.start();
     await lifecycle.cleanup();
@@ -78,15 +92,7 @@ describe("createCommentTypingReactionLifecycle", () => {
   });
 
   it("skips requests when reply_id is missing", async () => {
-    const lifecycle = createCommentTypingReactionLifecycle({
-      cfg: {} as ClawdbotConfig,
-      fileToken: "doc_token_1",
-      fileType: "docx",
-      replyId: undefined,
-      runtime: {
-        log: vi.fn(),
-      } as never,
-    });
+    const lifecycle = createTypingReactionLifecycle(undefined);
 
     await lifecycle.start();
     await lifecycle.cleanup();
@@ -95,25 +101,10 @@ describe("createCommentTypingReactionLifecycle", () => {
   });
 
   it("shares cleanup state so ambient cleanup and finally cleanup do not delete twice", async () => {
-    const lifecycle = createCommentTypingReactionLifecycle({
-      cfg: {} as ClawdbotConfig,
-      fileToken: "doc_token_1",
-      fileType: "docx",
-      replyId: "reply_1",
-      runtime: {
-        log: vi.fn(),
-      } as never,
-    });
+    const lifecycle = createTypingReactionLifecycle();
 
     await lifecycle.start();
-    await cleanupAmbientCommentTypingReaction({
-      client: { request } as never,
-      deliveryContext: {
-        channel: "feishu",
-        to: "comment:docx:doc_token_1:comment_1",
-        threadId: "reply_1",
-      },
-    });
+    await cleanupAmbientReply();
     await lifecycle.cleanup();
 
     expect(request).toHaveBeenCalledTimes(2);
@@ -144,25 +135,10 @@ describe("createCommentTypingReactionLifecycle", () => {
         data: {},
       });
 
-    const lifecycle = createCommentTypingReactionLifecycle({
-      cfg: {} as ClawdbotConfig,
-      fileToken: "doc_token_1",
-      fileType: "docx",
-      replyId: "reply_1",
-      runtime: {
-        log: vi.fn(),
-      } as never,
-    });
+    const lifecycle = createTypingReactionLifecycle();
 
     await lifecycle.start();
-    await cleanupAmbientCommentTypingReaction({
-      client: { request } as never,
-      deliveryContext: {
-        channel: "feishu",
-        to: "comment:docx:doc_token_1:comment_1",
-        threadId: "reply_1",
-      },
-    });
+    await cleanupAmbientReply();
     await lifecycle.cleanup();
 
     expect(request).toHaveBeenCalledTimes(3);