From 61564147f3bfe0204d16f87866158b0bbfffaf06 Mon Sep 17 00:00:00 2001 From: Peter Steinberger Date: Tue, 21 Apr 2026 19:19:03 +0100 Subject: [PATCH] fix: break provider thinking import cycle --- src/plugins/provider-auth-input.test.ts | 12 ++++++++++-- src/plugins/provider-thinking.ts | 3 +-- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/src/plugins/provider-auth-input.test.ts b/src/plugins/provider-auth-input.test.ts index 0f990107146..bc6fdc1bb9f 100644 --- a/src/plugins/provider-auth-input.test.ts +++ b/src/plugins/provider-auth-input.test.ts @@ -64,6 +64,13 @@ function setMinimaxEnv(params: { apiKey?: string; oauthToken?: string } = {}) { } } +function currentMinimaxTestEnv(): NodeJS.ProcessEnv { + return { + MINIMAX_API_KEY: process.env.MINIMAX_API_KEY, + MINIMAX_OAUTH_TOKEN: process.env.MINIMAX_OAUTH_TOKEN, + }; +} + async function ensureMinimaxApiKey(params: { config?: Parameters[0]["config"]; env?: Parameters[0]["env"]; @@ -76,7 +83,7 @@ async function ensureMinimaxApiKey(params: { }) { return await ensureMinimaxApiKeyInternal({ config: params.config, - env: params.env, + env: params.env ?? currentMinimaxTestEnv(), prompter: createPrompter({ confirm: params.confirm, note: params.note, @@ -119,7 +126,7 @@ async function ensureMinimaxApiKeyWithEnvRefPrompter(params: { }) { return await ensureMinimaxApiKeyInternal({ config: params.config, - env: params.env, + env: params.env ?? currentMinimaxTestEnv(), prompter: createPrompter({ select: params.select, text: params.text, note: params.note }), secretInputMode: "ref", // pragma: allowlist secret setCredential: params.setCredential, @@ -179,6 +186,7 @@ async function ensureWithOptionEnvOrPrompt(params: { token: params.token, tokenProvider: params.tokenProvider, config: {}, + env: currentMinimaxTestEnv(), expectedProviders: params.expectedProviders, provider: params.provider, envLabel: params.envLabel, diff --git a/src/plugins/provider-thinking.ts b/src/plugins/provider-thinking.ts index 34d64a60ca5..1c6e700a1e0 100644 --- a/src/plugins/provider-thinking.ts +++ b/src/plugins/provider-thinking.ts @@ -1,5 +1,4 @@ import { normalizeProviderId } from "../agents/provider-id.js"; -import { resolveProviderRuntimePlugin } from "./provider-hook-runtime.js"; import type { ProviderDefaultThinkingPolicyContext, ProviderThinkingProfile, @@ -50,7 +49,7 @@ function resolveActiveThinkingProvider(providerId: string): ThinkingProviderPlug if (activeProvider) { return activeProvider; } - return resolveProviderRuntimePlugin({ provider: providerId }); + return undefined; } type ThinkingHookParams = {